Clementine: memory leaks when parsing non-utf8 tags

[Lavande]

I have three flac files which contains non-utf8 tags.
When I open clementine, it starts consuming about 80M memory, but then this suddenly goes up to nearly 100% of my total memory.
While this happens, the terminal shows:
17:14:37.824 ERROR logging:55 gst_tag_parse_extended_comment: assertion 'g_utf8_validate (ext_comment, -1, NULL)' failed
17:14:37.825 ERROR logging:55 gst_tag_parse_extended_comment: assertion 'g_utf8_validate (ext_comment, -1, NULL)' failed
So I moved two of these files out of the library directory and left one there to test.
Then I started clementine again, the same happened.
However, if I clear all the tags of the flac file and run clementine, everything's fine.

[davidsansome]

Can you upload one of the bad flac files somewhere so we can take a look?

[Lavande]

It's here.
http://ubuntuone.com/0GzTZVYfpWbNMrwrxcFPr2
Please tell me if you've finished downloading and I'll stop publishing.

[davidsansome]

Downloaded.

I get the same error messages in the log but I can't reproduce the increase in memory usage - it stays constant for me.

[davidsansome]

I've mirrored this file (https://docs.google.com/file/d/0Byds9jlkR0IxWkhkb19BS1dWXzg) if anyone else wants to take a look after you delete it.

[Lavande]

I reproduced the bug this morning.
Could you try the following procedures?

1. Make sure the problematic flac file is not in the library directory
2. Start clementine
3. Move that flac file into your library directory, using your file manager (e.g., thunar)
4. In clementine, click "files" on the left side bar, find the flac file, and drag it into the playlist.
   Then the CPU usage should increase dramatically and two seconds later memory usage jumps up to infinite.
   (Version 1.2.1 from ppa:me-davidsansome/clementine)

[ppkt]

@Lavande, I was trying to reproduce problem, using file from https://docs.google.com/file/d/0Byds9jlkR0IxWkhkb19BS1dWXzg and following yours steps, but without any success. Could you confirm if problem is still present on latest release?
I've checked version 1.2.3

[Lavande]

@ppkt Yes, the bug is still there.
Now I'm using clementine 1.2.3 on ubuntu studio 14.04 (64bit). I followed the procedures I pasted above on 16 Jan and reproduced the bug.
However, there's a little difference. When I first encountered this bug several months ago, the memory usage was infinite which means I have no way to rescue my session but to shutdown my laptop by holding the power button for seconds. But now the memory usage of the single clementine process jumps to about 1G (I have 2G memory in total) which gives me the chance to start task manager to kill it though everything responds SLOWLY.

[JulianVolodia]

Dig diggy that issue...

Hi Pals! I have a joy with my lovely ASANs and getting over with some mem leaks.

@Lavande , are you still there and could you try to reproduce for this?

If there will be no response I will look for that but for now I will wait, if somebody could test it again (un)successfully ;->

Best regards and see You soon. :)

[Lavande]

Hi @JulianVolodia Memory doesn't leak any more with the same file now on clementine 1.3.1

[JulianVolodia]

@Lavande nice to hear that. I understand that if you don't see the bug now and could check that 1.2.3 had it and now it's gone, the issue could be closed. Am I right?

I am only contributor, but you are Author of this issue so please close it if you could.
Rise any other open issue or new issue if see some problems when using Clementine suite. :)))
Rise this issue if you saw regression of a bug.

Best regards! I will be more than happy to help you.

[Lavande]

@JulianVolodia Yes of course this should be closed since it's only in an ancient version which is gone now. Thanks for reminding me of this.

[JulianVolodia]

Great! :)