Cleave.js: React component with date formatting broken after 1.5.0

Created on 27 May 2019  路  7Comments  路  Source: nosir/cleave.js

Hey,

Date formatting seems to be broken in React component after 1.5.0.

No fork necessary, see console for error: https://jsfiddle.net/nosir/gLLsrxxf/

The error occurs in DateFormatter.js#L9.

Called in the react component here, Cleave.react.js#L147

Introduced in the PR #473.

We've downgraded to 1.4.10, which works as expected.

Most helpful comment

@nosir Can we go ahead and merge #478 ?

All 7 comments

Yes, we encountered the same thing.
Basically, DateFormatter signature changed(added minDate and maxDate), but not all the consumers(method callers) have been adapted.

@nosir Can we go ahead and merge #478 ?

Hello @nosir, is there a reason why this was not merged yet?

I too am getting the .split of undefined error. Please merge the fix if there is one.

Got
image

With
Options : {date: true, datePattern: ['Y', 'm', 'd']}

Any news on this? Can you release this? 鉂わ笍

Sorry guys, work stuff.
Thanks for the email @tcp
Released in 1.5.2 and npm published

Was this page helpful?
0 / 5 - 0 ratings

Related issues

drugoi picture drugoi  路  5Comments

YanikCeulemans picture YanikCeulemans  路  3Comments

ozkxr picture ozkxr  路  3Comments

shaileshrathod128 picture shaileshrathod128  路  6Comments

melbon picture melbon  路  3Comments