Clay: Add the new order-list icons to the Management Toolbar

Created on 26 Apr 2021  路  5Comments  路  Source: liferay/clay

The introduction to order-list-up and order-list-down were introduced in the Lexicon request by issue #4021 which adds the new icons to the @clayui/css package but we still need to update the Management Toolbar.

The Management Toolbar component does not deal directly with these actions because it is implemented as a low-level, so teams can compose the Management Toolbar in different variations without having to configure an API, so we just updated our examples to use the new icons.

  • Update the Management Toolbar documentation on clayui.com
  • Update the Management Toolbar Storybook and Templates
3.x clay-components documentation

Most helpful comment

I think we can update them all, but yeah, wouldn't hurt pinging @drakonux and @hold-shift. They're usually hyper-responsive and I'm sure they can give us a straight answer right away 鉂わ笍

All 5 comments

The Management Toolbar component does not deal directly with these actions because it is implemented as a low-level, so teams can compose the Management Toolbar in different variations without having to configure an API, so we just updated our examples to use the new icons.

Hey @matuzalemsteles, just wanted to note here that we (Infra) own our own implementation of High Level Management Toolbar that uses the icon so I think it should be considered as part of this effort when the new clay version gets merged ;)

@jbalsas Oh yeah, thanks Chema! I'll take care of that when the release comes out.

In addition to the Management Toolbar, I found a couple of places wherewe should _consider_ updating this too:

  • liferay-frontend:management-bar-sort uses 2 buttons to switch order. Interaction here seems a bit different as buttons signal the action of setting an order, not the current ordering.
    image
  • dataset management bar mimics the "original" management bar with two separated arrow icons to offer per column order options. This is a bit tricky as more than one column may offer sort buttons, meaning that there are cases where sort is not defined for a given column.
    image

@jbalsas as both cases seem connected with these icons, but have their own specificities, we may want to see what to do. I'm leaning towards doing a quick check with design to consider the cases one by one before moving forward.

I think we can update them all, but yeah, wouldn't hurt pinging @drakonux and @hold-shift. They're usually hyper-responsive and I'm sure they can give us a straight answer right away 鉂わ笍

This issue has been merged and will be released in DXP at https://issues.liferay.com/browse/LPS-130562

Was this page helpful?
0 / 5 - 0 ratings

Related issues

kresimir-coko picture kresimir-coko  路  3Comments

joseigor picture joseigor  路  5Comments

drakonux picture drakonux  路  4Comments

bryceosterhaus picture bryceosterhaus  路  5Comments

brunofarache picture brunofarache  路  5Comments