Clay: [Date Picker] Date Range

Created on 16 Mar 2021  路  10Comments  路  Source: liferay/clay

Hi Clay team,

Due to LEXI-1127 team-tango has requested a new feature for the date picker component.

Date Range

I said feature because I can't say if it's a feature or a variant. We documented it as a variant because it has two parts to introduce the date but except that it's just a change in the behavior of selecting dates. However, you must guide us and decide what this will be.

Please review the definition added to the original date picker document.

ps. We would like to introduce some improvements about input masking BUT we don't want to propose those changes now because team-tango didn't request those changes and we don't want to slow down the development of this request. If you say it would be good to propose it soon please let us know and we will work as soon as possible to introduce new changes in the main component.

ps2. Besides we would like to renew all the definition doc so we plan to update it on LEXI-975

3.x clay-css rfc

Most helpful comment

I'm just going to reopen this because @diegonvs is working on the component. #4008

EDIT: Thinking better of the track on Jira, I will create another issue.

Really appreciate it. no one ever had thought in Jira before 馃槶 Thanks.

All 10 comments

For the highlighted items, will we have hover and active (mousedown) states for it?

Yeah, exactly the same no changes, as they were a no highlighted element.

PS. We plan to move the current definition doc to Confluence. So we will review everything in deep to have a more clear definition.

Nice, thanks @drakonux

Hey @drakonux, answering a few things:

  • Mask: Well I think this is really important with the addition of range but it is not mandatory, so we can leave it to implement later because we will probably have to spend a little more time on it.
  • Variant: I think we can keep it as a component variation, we did the same for Time Picker. In the end, in the component, we will just add a few more props to activate this variation.

About the behaviors described in the document I seem clear, thanks @drakonux!

So it seems we have clarity on the requirements here, based on what I read above. Shall we add this to the next (or an upcoming milestone) so that Tango folks can have an idea of when this is going to get underway and into liferay-portal?

cc @brunofernandezg

Hey @wincent I'm going back to Infra from tomorrow but still part-time until the end of the migration, I don't know if this will be ready by April 7th, maybe move to the 21st milestone so I can review all the pending, @diegonvs is also coming back with a lot of time...

Hey @drakonux @hold-shift,

What will happen when the user clicks on the dot button?

image

By default it will select the current Date.

What do you expect for the date range?

I would suggest focusing on the start date but it will break the logic for non-date-range usages, which is focusing on the current date.

I'm just going to reopen this because @diegonvs is working on the component. #4008

EDIT: Thinking better of the track on Jira, I will create another issue.

I'm just going to reopen this because @diegonvs is working on the component. #4008

EDIT: Thinking better of the track on Jira, I will create another issue.

Really appreciate it. no one ever had thought in Jira before 馃槶 Thanks.

This issue has been merged and will be released in DXP at https://issues.liferay.com/browse/LPS-129362

Was this page helpful?
0 / 5 - 0 ratings

Related issues

drakonux picture drakonux  路  4Comments

bryceosterhaus picture bryceosterhaus  路  5Comments

bicienzu picture bicienzu  路  3Comments

hold-shift picture hold-shift  路  3Comments

dgarciasarai picture dgarciasarai  路  4Comments