Clay: ModalBody height fixed to 160px if Iframe

[FabioDiegoMastrorilli]

In case we use modals to display iframes, the body height is fixed to 160px which quite a small height. This doesn't work well with most of our use cases

Note: the issue disappear on full-screen modals.

[pat270]

@FabioDiegoMastrorilli what kind of behavior would you like to see? Lexicon Team has no definition for this. I could add a modifier class on modal to make a modal expand to the full height of the browsers window.

Edit: Unfortunately I'm unable to make it fit based on the content inside theiframe. I have no access to it.

Something like:

[jbalsas]

/cc @drakonux

[FabioDiegoMastrorilli]

@pat270 a full screen modifier and a large one would be helpful :)

I don't know if it is possible, but even changing the default height might be a solution if doesn't break anything.

From what I've seen so far 450px fits well with most of our designs.

[drakonux]

From our point of view, the body height of a modal window should not be fixed. Product teams should be able to set a height value with a default height preset or choose to let it grow as the content within defines.

We can consider to redefining the different sizes or behaviors if you need (open a request in LEXI).

ps. could we have a default height value??

[FabioDiegoMastrorilli]

Hi @drakonux , in some scenarios we don't know exactly the height of the content so we should rely on fixed height. A set of presets would be very useful for us

[pat270]

@FabioDiegoMastrorilli @drakonux I added fixed height modals with arbitrary heights. We can change them once we figure out what we need. The classes modal-height-full (window height), modal-height-sm (250px), modal-height-md (450px), modal-height-lg (650px), modal-height-xl (800px) can be added to modal to apply the respective styles.

[FabioDiegoMastrorilli]

@pat270 perfect! :) Thank you