Class-validator: feat: new isLocale validator

[rubiin]

I was working on a project that passed the language header to request the response in desired language. However I could not find it in the class-validator. How about making one. Can do a pr

[rubiin]

@vlapo what do u say about this

[vlapo]

I think we have one PR about extending error messages https://github.com/typestack/class-validator/pull/238. But this is kind of advanced topic and I do not decide how to handle it, yet.

[rubiin]

i mean do we have something to check whether a given string is a valid language like isLanguage or isLocale ? @vlapo

[rubiin]

I checked validator.js but there is no such validator available perhaps we have to make a new one @vlapo

[vlapo]

Looks like there is FR https://github.com/validatorjs/validator.js/issues/954 and PR https://github.com/validatorjs/validator.js/pull/1072. I would like to wait and use validatorjs function (if PR will be merged in some reasonable time).

[arkus7]

@vlapo @rubiin mentioned PR has been merged :)

https://github.com/validatorjs/validator.js/pull/1072

[rubiin]

@arkus7 thanks for the info. I will be doing a pr shortly

[johannesschobel]

merged but not released :D

[johannesschobel]

Dear @vlapo and @rubiin ,
theisLocale() function has now been released in validatorjs 13.0.0!

[rubiin]

let md work on that

On Mon, Mar 23, 2020 at 4:35 PM Johannes Schobel [e-mail]
wrote:

Dear @vlapo https://github.com/vlapo and @rubiin
https://github.com/rubiin ,
theisLocale() function has now been released in validatorjs 13.0.0!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/typestack/class-validator/issues/425#issuecomment-602519348,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB6XK26KWH44GBSC2YYDYXDRI45H5ANCNFSM4I2YXEGA
.

[vlapo]

@rubiin please also create new added validators (isEthereumAddress, isIBAN, ...)

[rubiin]

Sure

On Wed, Mar 25, 2020, 2:40 AM Vlad Poluch [e-mail] wrote:

@rubiin https://github.com/rubiin please also create new added
validators (isEthereumAddress, isIBAN, ...)

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/typestack/class-validator/issues/425#issuecomment-603499848,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AB6XK2YTX7DPM2IBU67D5ZDRJEM4BANCNFSM4I2YXEGA
.

[vlapo]

@rubiin please wait with this changes. I have one big PR with lot of changes almost ready.

[rubiin]

@vlapo sure

[vlapo]

@rubiin I synced validatorjs lib to v13 (isLocale included). Thank you for help with provide this new validator.

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.