Class-validator: fix: google-libphonenumber is huge

Created on 8 Aug 2018 · 9Comments · Source: typestack/class-validator

Hi,

I don't know whether you are aware, but the dependency of this library, google-libphpnenumber takes almost 0.5MB of size in production bundle.
I use your library in my package and I can't increase the version number because of this as my bundle rises from 800KB to 1300KB because of this.

If this is by design then close the issue, I am just raising awareness in case you were not aware.

high fix

Source

Stupar92

👍22 👀1

Most helpful comment

Hi!

There is already an in-progress PR for this at #258.

NoNameProvided on 4 Nov 2018

👍3

All 9 comments

I agree with OP. The library google-libphonenumber is huge. By adding it to class-validator it means that using it in a browser scenario becomes problematic due to the bundle size. I vote to remove google-libphonenumber from class-validator.

rmuchall on 1 Oct 2018

You are right. Hopefully, I can fix this at the weekend, alongside with the other issues. I have been pretty busy in the latest month, but I will take a week off to work on the Typestack libraries. And again, sorry for the late response.

NoNameProvided on 16 Oct 2018

👍1

@NoNameProvided
That's great!
Please let me know if you require any assistance. I have some free time for the next few weeks and I'd be happy to help.
Thanks.

rmuchall on 16 Oct 2018

Hi!

There is already an in-progress PR for this at #258.

NoNameProvided on 4 Nov 2018

👍3

Hi there, any news?

Our build just thrown an error on CI after importing a shared class between the backend and the frontend into the frontend. It's a simple class with only @IsOptional and @isString but now our bundle exceed the 2.5mb limit that we've set on our bundles.

Here's a visualisation of the space required by that lib (easy to compare with angular):