Class-validator: @IsUrl options not works

[sanex3339]

It seems what @IsURL options not works at all.

   /**
     * @type {string}
     */
    @IsString()
    @ValidateIf((options: IOptions) => Boolean(options.sourceMapBaseUrl))
    @IsUrl({
        require_protocol: true,
        require_valid_protocol: true
    })
    public readonly sourceMapBaseUrl: string;

Input string google.ru -> validator does not trows any errors.

[sanex3339]

ping

[pleerock]

as you know IsUrl just delegates its work to https://github.com/chriso/validator.js isUrl. Can you check if what you try to achieve works with original function? e.g. require("validator").isURL(value, options)

[sanex3339]

https://runkit.com/58259b2fcfbc960014b4591f/582ab7ae430fac0014ffc6d4

    require("validator").isURL('google.ru', {
        require_protocol: true,
        require_valid_protocol: true
    })

returns false

Looks like class-validator not passes options for isURL validator.

[pleerock]

try fix in 0.6.5

[sanex3339]

ts error with 0.6.5
Cannot find type definition file for 'es6-shim'.

[default] /home/user/javascript-obfuscator/node_modules/class-validator/decorator/decorators.d.ts:2:1 
    Cannot find type definition file for 'es6-shim'.
[default] /home/user/javascript-obfuscator/node_modules/class-validator/index.d.ts:2:1 
    Cannot find type definition file for 'es6-shim'.
[default] /home/user/javascript-obfuscator/node_modules/class-validator/validation/Validator.d.ts:2:1 
    Cannot find type definition file for 'es6-shim'.
[default] /home/user/javascript-obfuscator/node_modules/class-validator/validation/ValidatorConstraintInterface.d.ts:1:1 
    Cannot find type definition file for 'es6-shim'.

[pleerock]

damn this is problem with new @types system... I'll fix it, but despite the compiler errors, is isUrl working now?

[sanex3339]

looks like now it works

[pleerock]

fixed your issue in 0.6.6

[sanex3339]

Amazing, thank you!