Clarity: Clarity Tabs crash with Angular 9

Created on 8 Jan 2020  路  13Comments  路  Source: vmware/clarity

Describe the bug

Clarity Tabs crash at runtime with the following error:

zone-evergreen.js:365 ERROR Error: ASSERTION ERROR: index
    at throwError (core.js:1364)
    at assertLessThan (core.js:1338)
    at ViewContainerRef_._adjustIndex (core.js:17412)
    at ViewContainerRef_.insert (core.js:17345)
    at ViewContainerRef_.createComponent (core.js:17307)
    at new ClrTabLink (clr-angular.js:17440)
    ...

How to reproduce

I have created a basic reproduction example:

  • new Angular project
  • Update Angular (9.0.0-rc.7)
  • Install Clarity (3.0.0-rc.5)
  • Serve -> Open Page -> Open Dev Tools

Published on GH: https://github.com/TekSiDoT/ng9-clr-tabs-repro
Stackblitz does not yet seem to properly support either Angular 9 or its CLI.

Expected behavior

Tabs should be usable without runtime crash.

Versions

App

  • Angular: 9.0.0-rc.7
  • Node: -
  • Clarity: 3.0.0-rc.5

Device:

  • Type: MB Pro 2016
  • OS: Catalina
  • Browser: Checked with Chrome / FF latest

Additional notes

Related with https://github.com/angular/angular/issues/33924 . However, the merged Fix (https://github.com/angular/angular/pull/34052) (published in Angular 9.0.0-rc.4) does not seem to have fixed the issue for Clarity.

@clangular tab fixed bug

All 13 comments

Thanks, we're still slogging through the updates and we'll add this to our list of things to review.

@TekSiDoT have you tried this with latest Clarity and Angular rc?

I had to work around https://github.com/vmware/clarity/issues/4185, unfortunately, the issue persists with Angular rc9 and Clarity rc6.

This error also occurs in Clarity 2.3.1 in combination with Angular 9.0.0-rc.9.

Angular CLI: 9.0.0-rc.9
Node: 13.6.0
OS: linux x64

Angular: 9.0.0-rc.9
... animations, cli, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router
Ivy Workspace: Yes

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.900.0-rc.9
@angular-devkit/build-angular     0.900.0-rc.9
@angular-devkit/build-optimizer   0.900.0-rc.9
@angular-devkit/build-webpack     0.900.0-rc.9
@angular-devkit/core              9.0.0-rc.9
@angular-devkit/schematics        9.0.0-rc.9
@angular/cdk                      9.0.0-rc.8
@angular/material                 9.0.0-rc.8
@ngtools/webpack                  9.0.0-rc.9
@schematics/angular               9.0.0-rc.9
@schematics/update                0.900.0-rc.9
rxjs                              6.5.4
typescript                        3.7.5
webpack                           4.41.2

Tried again with [email protected] and [email protected], error is still reproducable, but the error message changed a bit:

image

We haven't released a version of Clarity that properly supports Angular 9, see #4232. This should be resolved in that branch, but leaving open for the moment to ensure.

Angular 9 has now been released. Seeing this issue with Angular 9.0.0 and Clarity 2.3.2.

Angular 9 released and the same happens with [email protected]

We are still addressing issues with angular 9. I should have a release in the next few days that addresses the issues.

Please follow #4232 PR for updates and wait for our next release.

Fixed by #4232

Confirmed Working, thank you!

Hi there 馃憢, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

Was this page helpful?
0 / 5 - 0 ratings