Clarity: Date Picker don't mark form as dirty

Created on 11 May 2018  路  5Comments  路  Source: vmware/clarity

Select one ... (check one with "x")

[x ] bug
[ ] feature request
[ ] enhancement

Expected behavior

When you select a date in the date picker, the form is marked as dirty.

Actual behavior

When you select a date in the date picker, the form is not marked as dirty.

Reproduction of behavior

Click the date picker icon to open the component and select a date.
The form is marked as dirty only when typing the date with the keyboard
https://stackblitz.com/edit/clarity-light-theme-v11-6quune

Environment details

  • Angular version: 5.2.1

  • Clarity version: 0.11.16

  • OS and version:

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

bug

All 5 comments

@williangd: Thanks for reporting this issue. We will take a look and get back to you.

Looks like we need to call this https://angular.io/api/forms/AbstractControl#markAsDirty when a date is selected from the date picker.

cc: @youdz @gnomeontherun

Yup, that should do it. Same with markAsTouched(), which I'll need for forms refactoring anyways.

Hi there 馃憢, this is an automated message. To help Clarity keep track of discussions, we automatically lock closed issues after 14 days. Please look for another open issue or open a new issue with updated details and reference this one as necessary.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Vad1mo picture Vad1mo  路  3Comments

Thatkookooguy picture Thatkookooguy  路  3Comments

beaker1977 picture beaker1977  路  3Comments

JohannesRudolph picture JohannesRudolph  路  4Comments

aaronfrost picture aaronfrost  路  3Comments