Clarity: Refactor internal use of old popovers

Created on 8 Dec 2017  路  11Comments  路  Source: vmware/clarity

Need to clean up uses of the old popover implementation and replace with updated version.

  • [ ] Button Group Overflow
  • [x] Datagrid Filters
  • [x] Dropdowns
  • [ ] Signposts
  • [ ] Tooltips
Epic enhancement

Most helpful comment

Any progress on any of the affected components? Can we expect something in the next release?

Cut off signposts are really an annoying issue ... would be great if we could get an ETA at least for them.

Thanks!

All 11 comments

@gnomeontherun
What's up with this ticket?

This is a tracking ticket to remove the old popover implementation, which is used internally in the components listed above.

@gnomeontherun: The above components use the new popovers. Datagrid filters and button groups I believe use the old one

Then we can fix the description :)

done

Is there any ETA for signposts to work with the smart popovers? As we currently need to fix it with z-index on the parent to overlay other content.

Any progress on any of the affected components? Can we expect something in the next release?

Cut off signposts are really an annoying issue ... would be great if we could get an ETA at least for them.

Thanks!

Is there some progress regarding signposts? - Seems like the number of issues closed in favour of this is growing.

Used in datagrid it causes some really strange behaviour. In the last rows the table gets a scrollbar when opening the signpost and the user has to scroll to see the signpost content.

Thx

This ticket was generated before our strategy with Core was defined, where we had intended to bring the smart popovers into all of the Angular components. The problem is that the smart popovers need further refinement to work with signposts and tooltips, and our efforts with Clarity Core will address this problem more holistically.

To that end, I'm going to close this issue as something we aren't going to complete because of concerns about duplicating efforts to do this in Clarity Angular and Clarity Core, as well as the concern about breaking changes that appear to be required to make it happen.

For those watching this issue, the solution for the cutoff type issues will be to use the Clarity Core implementations when they are available, or to use manual positioning settings to keep the popovers in view without clipping.

@gnomeontherun Is there an issue to keep track and get notified when the cutoff type bugs (e.g. signposts) are solved with Clarity Core?

@twittwer
They will be fixed when signposts are introduced in Clarity Core. There are dependencies we are working on now to get to signposts but right now signposts are blocked until the dependencies are completed.

Was this page helpful?
0 / 5 - 0 ratings