Ckeditor5: softBreak element should be isContent

[scofalik]

📝 Provide detailed reproduction steps (if any)

As in the title. At the moment, softBreak element is not isContent. It should be. We should review all elements we have in the editor and check whether their schema definitions are correct.

[niegowski]

Also model.hasContent() should be updated to properly handle ignoreWhitespaces option for softBreak.

[jodator]

It should be.

Without digging into the whole story it will be hard to tell why. Could you elaborate a bit more on this?

[Reinmar]

Agree with @jodator that it's not that simple to say that soft break is a content. Actually, I think it is not.

<p><br><br><br></p>

This is treated (or at least - should be) as an empty editor when trimming content. So, to me, this is not a content. Just like an empty <p> element isn't.

[scofalik]

Agree with @jodator that it's not that simple to say that soft break is a content. Actually, I think it is not.

<p><br><br><br></p>

This is treated (or at least - should be) as an empty editor when trimming content. So, to me, this is not a content. Just like an empty <p> element isn't.

Hm, interesting point of view.

On the other hand, there is a significant difference between:

<p>Foo<br />Bar</p>

And:

<p>FooBar</p>

It works kind of like space character. I think this is content because it changes how we perceive what was written in the editor. It's not styling but it has an impact on the editor data. There is a change in the data.

Below can still be regarded as empty data:

<p>    </p>

But I doubt you would say that space character is not content.

Having softBreak as isContent element would be positive when it comes to handling it in features that want to automatically integrate with editor data, like track changes or versioning.