Ckeditor5: Define interface for focusable views

[oskarwrobel]

I want to use CKE5 as an input together with Submit and Cancel buttons and I want to use FocusCycler to cycle focus around this three form controls. Unfortunately, EditorUIView is not a valid FC child.

[Reinmar]

It'd be good to define FocusableViewInterface (or just FocusableView, we're not consistent here and I'm unsure which is better) and define that options.focusables is an array of those.

And mark (using @implements ofc) which views implement it.

[oleq]

Unfortunately, EditorUIView is not a valid FC child.

What do you mean by that?

[oskarwrobel]

Does not have focus() method.

[oleq]

I see no reason why classes like ClassicEditorUIView could not implement focus() method. They know about editable(s) (InlineEditableUIView in such case) and EditableUIView could implement focus() too (it's simply this.element.focus()). WDYT?

[oskarwrobel]

Ok, I see this a matter of specific editor implementation, not something general.
I don't need to add a focusable interface to the ClassicEditorUIView and I'm not sure if ClassicEditor needs it.

I'm closing this ticket.

[oleq]

I'm not sure what I did but I'm glad it helped ;-)

[Reinmar]

But why did you close the ticket? I'd actually like to see a proper interface definition and marking classes which implement it. Otherwise, it will be confusing for someone else in some time.