Ckeditor5: Widget has fillers

Created on 16 Dec 2016  路  4Comments  路  Source: ckeditor/ckeditor5

image

image bug

Most helpful comment

All 4 comments

I've pushed my progress to t/19 branch. We decided that we will leave this for now as the issue is bigger than it looked at the beginning.
Problem is that sometimes browser put selection inside contenteditable="false" element. I wanted to listen on selectionChange event and fix the selection before it is stored in model. Unfortunately, this causes some side-effects:
output

This happens:

  1. Selection is dragged, it ends up inside nested editable, so it's fixed to select whole widget.
  2. Selection is converted to model selection.
  3. Model to view selection conversion is done, widget is selected, and selection is put inside fake selection container.
  4. Selection is dragged further so 1st step occurs again.

In short, we are in a process of dragging selection in browser and at the same time we want to put selection inside fake selection container.

Another TC which we identified to be caused by the filler: https://github.com/ckeditor/ckeditor5-image/issues/69.

Was this page helpful?
0 / 5 - 0 ratings