Ckeditor5: Missing token destroy

Created on 3 Nov 2017  路  3Comments  路  Source: ckeditor/ckeditor5

CloudServices class should destroy token class on self-destroy, and token class should stop refreshing on self-destroy. Otherwise, token won't stop refreshing after editor destroy.

cloud-services bug
Source
picture oskarwrobel

All 3 comments

Thanks, @oskarwrobel! I forgot to implement it.

ma2ciek picture ma2ciek on 3 Nov 2017
👍1

Note that we should not use protected _stopRefreshing. Instead, this class should have public destroy method.

pjasiun picture pjasiun on 3 Nov 2017
👍1

I just wrote it ~ 1-2 minutes ago https://github.com/ckeditor/ckeditor-cloudservices-core/issues/9 :D

ma2ciek picture ma2ciek on 3 Nov 2017
Was this page helpful?
0 / 5 - 0 ratings

Related issues

pjasiun picture pjasiun  路  3Comments
oleq picture oleq  路  3Comments
hybridpicker picture hybridpicker  路  3Comments
Reinmar picture Reinmar  路  3Comments
PaulParker picture PaulParker  路  3Comments