Ckeditor5: Link highlight resembles the selection

Created on 9 Mar 2018  路  5Comments  路  Source: ckeditor/ckeditor5

image

You have to think for second to understand what's selected here.

accessibility

Most helpful comment

I used the highlight color that I proposed with the box-shadow. WDYT?

screen shot 2018-03-22 at 10 59 55

All 5 comments

I'm for changing it to

--ck-color-link-selected-background: hsl(201, 100%, 96%);

since this is not an a11y feature and we don't have to be super contrast-compliant in this case IMO.

image


The outline that we added in https://github.com/ckeditor/ckeditor5-theme-lark/issues/155 causes some nasty bright line across the native selection. When disabled, it looks OK
image

cc @dkonopka

since this is not an a11y feature and we don't have to be super contrast-compliant in this case IMO.

+1

--ck-color-link-selected-background: hsl(201, 100%, 96%);

馃憤

When disabled, it looks OK

So we should drop outline solution, and try proposed.

box-shadow: 0 0 0 1px var(--ck-color-link-selected-background);

outline:
screen shot 2018-03-19 at 11 43 03

Box-shadow solution:
screen shot 2018-03-19 at 11 44 19

I used the highlight color that I proposed with the box-shadow. WDYT?

screen shot 2018-03-22 at 10 59 55

In this screenshot, it looks a bit too light for me, but I guess that the best way to find out whether it works in real life is to see it live :)

Was this page helpful?
0 / 5 - 0 ratings

Related issues

benjismith picture benjismith  路  3Comments

pandora-iuz picture pandora-iuz  路  3Comments

jodator picture jodator  路  3Comments

Reinmar picture Reinmar  路  3Comments

oleq picture oleq  路  3Comments