Ckeditor5: Enlarge link's highlight background

[Reinmar]

Current:

With 1px outline:

WDYT?

[Reinmar]

cc @oleq @dkonopka

[oleq]

LGTM. Is this some padding or an actual outline?

[dkonopka]

Looks good to me too, it's padding I guess?

[Reinmar]

No, no padding. Padding is dangerous in inline stuff. Just a 1px outline.

[Reinmar]

We could perhaps even play with the colour of this outline. I wonder if it would look any good if it was e.g. slightly darker, to create a kind of a border. Something which will indicate the integrity of this link (not sure how to tell this).

[oleq]

Some ideas:

[Reinmar]

Hm... From all these, I'd choose the 1st option (solid). But at the same time, I can see that we don't have enough space inside that box, so it gets too crowdy in there. So, I'd prefer the same colour as the bg.

[dkonopka]

I'm for keeping it simple - outline with the same background looks 👍

[oleq]

@dkonopka Can you create a PR?

[dkonopka]

Guys, what do you think in the situation with highlight feature?
Should .ck-link_selected change background on children elements like <mark>?

Current

Proposal with outline

Proposal with outline & background

[Reinmar]

Proposal with outline & background

👍

Link highlight, just like selection's highlight, should have the precedence.