Ckeditor5: Better detection of heading rows

Created on 24 May 2018 · 6Comments · Source: ckeditor/ckeditor5

Right now when upcasting table row it is assumed that headingRows attribute is calculated only from number of rows of first <thead> section (following <thead> sections are treated as normal rows).

The other case might be when a <table> element does not have <thead> nor <tbody> sections or a <tbody> section with "pseudo table head".

The "pseudo table head" is a row which contains only <th> elements.

We might detect such rows as heading rows because right now they will be counted as heading columns which will result in wrong table:

For instance such table:

<table>
    <tr>
        <th>a</th>
        <th>b</th>
    </tr>
    <tr>
        <th>c</th>
        <td>d</td>
    </tr>
</table>

will be converted to a model representation:

<table headingColumns="2">
    <tableRow>...</tableRow>
    <tableRow>...</tableRow>
</table>

but should be:

<table headingColumns="1" headingRows="1">
    <tableRow>...</tableRow>
    <tableRow>...</tableRow>
</table>

table 2 improvement

Source

jodator

All 6 comments

This will be important for pasting. And for handling some legacy data (although, of course, CKEditor 4 does produce <thead> element so I rather mean a content produced by other editors).

Reinmar on 25 May 2018

Another case - non-semantic heading section in <tbody>:

<table>
  <caption>Concerts</caption>
  <tbody>
  <tr>
    <th>Date</th>
    <th>Event</th>
    <th>Venue</th>
  </tr>
  <tr>
    <td>12 Feb</td>
    <td>Waltz with Strauss</td>
    <td>Main Hall</td>
  </tr>
  <tr>
    <td>24 Mar</td>
    <td>The Obelisks</td>
    <td>West Wing</td>
  </tr>
  <tr>
    <td>14 Apr</td>
    <td>The What</td>
    <td>Main Hall</td>
  </tr>
  </tbody>
</table>

Edit: reported also in ckeditor/ckeditor5-table#109.

jodator on 31 Jul 2018

👍1

@Reinmar We might consider a simple fix for this. A case when there is a row with only <th> elements in it looks like heading row and should not be taken into consideration when detecting number of heading columns.

It keeps coming back from time to time: ckeditor/ckeditor5-table#109, ckeditor/ckeditor5-table#140.

jodator on 18 Oct 2018

👍1

A case when there is a row with only <th> elements in it looks like heading row and should not be taken into consideration when detecting number of heading columns.

👍

In general, I think we need two separate mechanisms:

For detecting header rows. If thead is present, then the number of rowa in that thead. If not, then we should count all trs that have only th children.
For detecting header cols. That'd require checking how many ths are there at the beginning of each rows. The minimal number is the number of heading cols. For example:
```
tr: th, th, td, td
tr: th, td, th, th
tr: th, th, td, td
```
That'd be 1 because in the second row there's only one th at the beginning.

If you agree that this algorithm makes sense, then we could try to go this way. I don't mean that we have to rewrite what we have right now, but we should keep it in mind when making decisions about fixing some issues.

Reinmar on 18 Oct 2018

👍1