Ckeditor5: Should the toolbar icon be improved?

[oleq]

The toolbar icon in the MVP looks as follows

which

• on one hand could me misleading because the feature offers way more than videos, e.g. Twitter posts or Google Maps,
• OTOH makes sense because the word "media" has strong association with videos (also audio and photos) and most likely the users will look for something like that in the toolbar,
• OTTH makes sense because most of the embeds will, indeed, be videos

So what I proposed is a trade–off between the semantics of the feature (media embed is more than videos) and commonly used patterns (media is mostly videos these days).

There's also the matter of limited space in the icon and the fact that we shouldn't overdo it which makes it hard to express the entire scope of the feature (a.k.a. "embed almost anything"). IMO in v4 we made a poor job depicting the feature

This icon is very vague and I'd rather avoid this kind of communication. I think an incomplete but precise communication is way better than that.

WDYT?

cc @dkonopka

[dkonopka]

In my opinion, there is no way to make 100% clear icon in this case, because like you said, it can be "everything" like Twitter, Google Maps, Reddit and hundreds of various type of content.

I definitely prefer much more the current icon than v4 (it looks like an article or some kind of note?) and I'd stay with "video icon" 👍

[pjasiun]

:+1: for the current icon. It is far more natural than the icon in CKE4.