Ckeditor5: The table in the migration guide is cropped

[oleq]

https://ckeditor.com/docs/ckeditor5/latest/builds/guides/migrate.html#configuration-options-compatibility-table

cc @msamsel @Reinmar

[Reinmar]

I guess this needs to be fixed in the styles. So cc @dkonopka.

[dkonopka]

Code block inside table breaks it, we are missing here white-space: normal.

[mlewand]

@dkonopka the problem with changing white-space for code element is that it will change its formatting:

mby scroll overflow? 🤔 just like we do for other wider code listings?

[dkonopka]

@mlewand It's not so easy to set overflow-x: scroll, because then we need to set some max-width of this element which stretch <table>.

That's why I decided to go with white-space: normal even if it changes code formatting. I see this is the first<code> inside <table>, so IMHO we can live with this changed code format.

But....it's possible to change table-layout: fixed then <code> looks good, but the column width is not as perfect as it should be.

[mlewand]

Why does its width exceed the parent constraints in the first place? 🤔 I think this is the issue that contributes to the problem.

I'm afraid that table-layout: fixed is a no-go option. Just imagine it will apply fixed, equal widths to each single table in our docs. The default layout strategy seems to make more sense than that.

If we can't come up with a reasonable reusable solution, I'm ok with simply hand correcting the code listing in this particular doc as a workaround.

[dkonopka]

As I can see, the table here is a plain html, so we can easily add extra CSS class (or inline style) and it will be working only for this table. I know it's not the best idea, but it could work. WDYT?

[mlewand]

Oh, in this case it's totally fine 👍 If it's for this table only, and just please fine-tune the first cell width, so that it has same width as now (with the default strategy).

The more width in second cell the less lines it will contain 🙂