Ckeditor5: [Edge] Editor doesn't get focus after dismissing the text alternative balloon

[Mgsy]

🐞 Is this a bug report or feature request? (choose one)

• Bug report

💻 Version of CKEditor

1.0.0-alpha2

📋 Steps to reproduce

1. Go to http://localhost:8125/ckeditor5-core/tests/manual/article.html.
2. Focus the image.
3. Open text alternative balloon.
4. Put the selection in Heading 1.
5. Try to type something.

✅ Expected result

You should be able to type in Heading 1.

❎ Actual result

The image toolbar is still visible and there is no possibility to type.

📃 Other details that might be useful

GIF

Notes

If you try to press Delete, it will work.

Other information

OS: Windows 10
Browser: Edge 16

[oleq]

It could somehow (?) be that the input in the text alt balloon retains the focus when the balloon disappears and the focus is not transferred to editable (the editable does not even get the blue outline) but it's actually lost.

Feels more like a bug in Edge than actual CKE problem but it looks critical to me, making the editor useless after a very common UI interaction. WDYT @Reinmar?

[Reinmar]

Checking document.activeElement may give an answer.

~I wouldn't be that surprised if the focus stayed in the input despite it disappearance. Does we manage the focus manually in helpers such as closeOnEsc() or let the browser decide? If the latter, then there may be a quite easy way to fix it.~

[Reinmar]

Uh, sorry, I misread the TC. So it seems to be an Edge bug and yep, it's quite severe.

[oleq]

We handle that manually but in the case of the clickOutsideHandler we leave it up to the browser. It could be that. @Mgsy, can you use this._hideForm( true ) there and see if the issue is gone?

[Reinmar]

Since, I'm not sure what this._hideForm( true ) is I guess @Mgsy will have hard time finding this out too :D

Whatever you find, if it's Edge, it must be reported.

[Mgsy]

Since, I'm not sure what this._hideForm( true ) is I guess @Mgsy will have hard time finding this out too :D

I guess @oleq asked to pass true argument to this._hideForm() inside clickOutsideHandler in imagetextalternative.js :)

After this change, problem has disappeared. Balloon has closed and focus appeared on the image.

[oleq]

Just make sure the same patch is also used in ckeditor5-link.

[Reinmar]

Since _hideForm() is private and always get true, can we just remove this param at all?

[Reinmar]

BTW, on Esc the focus should actually move back to the toolbar if it was there.

So, in the future, when working on a11y we'll need to remember which element hold focus before the form was opened and move focus back there. But that's future.

[FilipTokarski]

This bug is fixed in the new upcoming Edge v.79.0.309.56.

[Mgsy]

Fixed in the new Edge release.