Ckeditor5: gulp build --watch stopped watching changes.

Created on 24 May 2016 · 6Comments · Source: ckeditor/ckeditor5

Just after updating npm dependencies I've spotted that gulp doesn't refresh build after source file change. gulp-watch was updated yesterday https://github.com/floatdrop/gulp-watch/releases to 4.3.6. I've tried to downgrade to 4.3.5 and it helps.

Could someone confirm it?

bug

Source

oskarwrobel

Most helpful comment

Ok, I've found the root of the issue and reported it here: https://github.com/floatdrop/gulp-watch/issues/229

I found a way to make it work with current version of gulp-watch by creating globs with relative paths. We need to change this glob definition to this:

const glob = path.join( path.relative( config.ROOT_DIR, dirPath ), '@(src|tests)', '**', '*' );

But for now - let's wait for the gulp-watch maintainer to answer the issue.

szymonkups on 24 May 2016

👍2

All 6 comments

Checking...

Reinmar on 24 May 2016

Unfortunately I can confirm this.

Reinmar on 24 May 2016

I fixed the version temporarily: a38ce97.

Reinmar on 24 May 2016

Ok, I've found the root of the issue and reported it here: https://github.com/floatdrop/gulp-watch/issues/229

I found a way to make it work with current version of gulp-watch by creating globs with relative paths. We need to change this glob definition to this:

const glob = path.join( path.relative( config.ROOT_DIR, dirPath ), '@(src|tests)', '**', '*' );

But for now - let's wait for the gulp-watch maintainer to answer the issue.

szymonkups on 24 May 2016

👍2

Hey, gulp-watch maintainer here. We have just published [email protected] which fixes this issue. Please try it out and let us know if you experience any issues.

Special thanks to @szymonkups for helping us to identify the issue and test the patches.