Ckeditor4: Autolink typing support breaks integration with autoembed plugin

Created on 28 Aug 2018 · 5Comments · Source: ckeditor/ckeditor4

Type of report

Bug

Provide description of the task

On major branch tests are failing:
tests/plugins/autoembed

screen shot 2018-08-27 at 15 22 55

Other details

Browser: any
OS: …
CKEditor version: …
Installed CKEditor plugins: …

skip autolink regression confirmed major bug failingtest

Source

engineering-this

All 5 comments

Looks like a regression since it doesn't fail on master.

mlewand on 28 Aug 2018

Culprit: https://github.com/ckeditor/ckeditor-dev/commit/f9f688acaf5684c750c0eb51fd4d7ea27014f583
Manual test also fails: tests/plugins/autoembed/manual/autoembed.

It looks like autoembed doesn't work at all, as everything is converted into links.

engineering-this on 3 Sep 2018

Improved autolink plugin with typing support breaks integration with autoembed plugin. I will rename ticket title and labels thus it's autolink bug, not issue with autoembed tests.

jacekbogdanski on 4 Sep 2018

👍1

@jacekbogdanski Although it's not an issue with test I suggest to keep that label, so other devs can find this ticket, so we don't end up with duplicates.

engineering-this on 24 Sep 2018

👍1

Fixed with #2372.