It'd be nice to be able encode and decode spire numeric types like SafeLong, Rational, UInt or Algebraic. I have implemented some of them in a recent project and could contribute them if wanted :)
LukaJCB
All 7 comments
Sounds good to me! I think I'd prefer a new circe org repo rather than a module here, since e.g. Spire doesn't have 2.13.0-Mx artifacts yet, etc.
travisbrown
on 8 Jan 2019
Cool! What's the best way to get started on that? You create the repo and I'll make a PR? :)
LukaJCB
on 8 Jan 2019
Yep, just sent an invite: https://github.com/circe/circe-spire
travisbrown
on 8 Jan 2019
I'd recommend using something like circe-bson as a template (and adding the repo to scala-steward's list) to keep some kind of consistency, but definitely not required: https://github.com/circe/circe-bson
travisbrown
on 8 Jan 2019
Done! https://github.com/circe/circe-spire/commit/a6b334b5f7baf2164909a96808a4fdabb518713b
@travisbrown if you'd go for a quick review I'd be grateful :)
LukaJCB
on 8 Jan 2019
Looks good to me (I noticed one mention of circe-bson left over in the build.sbt, but can open a PR for it later). I also just tried to enable Travis CI and it's telling me "You don't have sufficient rights to enable this repo on Travis. Please contact the admin to enable it or to receive admin rights yourself."鈥攅ven though I created the repo myself. I'll try to get that worked out now.
travisbrown
on 8 Jan 2019
P.S. Travis CI is now working, and I opened https://github.com/circe/circe-spire/pull/2.
travisbrown
on 8 Jan 2019
Related issues
jonas
路
4Comments
darkfrog26
路
4Comments
Nr18
路
5Comments
migesok
路
3Comments
oscar-broman
路
7Comments
Most helpful comment
I'd recommend using something like circe-bson as a template (and adding the repo to scala-steward's list) to keep some kind of consistency, but definitely not required: https://github.com/circe/circe-bson