Cilium: helm: inconsistency in hubble-relay chart

[ghouscht]

Bug report

There is a little inconsistency in charts/hubble-relay/templates/deployment.yaml

Inside the if block the tag of the image is missing, if it is not set directly via hubble-relay.image.repository - see example below:

hubble-relay:
  image:
    repository: docker-remote.repo.pnet.ch/cilium/hubble-relay:v1.8.3
    tag: not relevant if .Values.image.repository is set and contains a /
hubble-ui:
  image:
    repository: quay-docker-remote.repo.pnet.ch/cilium/hubble-ui
    tag: v0.6.1

This is a bit misleading and not consistent with the behaviour of the hubble-ui subchart. Let me know if you'd like to clean this up. Things would also be a bit easier if the hubble-ui docker image would be on docker hub, this would allow us to use .Values.image.repository globally and just append the repository/tag to it for all deployments.

[gandro]

The {{- if contains "/" .Values.image.repository }} is consistent with our remaining deployments such as the cilium DaemonSet or the cilium-operator Deployment. So from that perspective, it is the hubble-ui chart which is inconsistent, not hubble-relay. If it makes things easier, please feel open a PR to add the if-statement to hubble-ui, that inconsistency is accidental.

As for mirroring the hubble-ui images on DockerHub, what do you think @genbit or @geakstr and @yandzee?

[ghouscht]

Sorry for the delay, had some days off I enjoyed without computers.
Thanks for the clarification @gandro, you're of course correct. I will take the time to look at this in the upcoming days. In the meantime is there any "progress" for mirroring the hubble-ui images to DockerHub? 😃

[Rolinh]

In the meantime is there any "progress" for mirroring the hubble-ui images to DockerHub? smiley

@ghouscht Available "very soon" :wink:

[kAworu]

@seanmwinn I believe this issue will be fixed by https://github.com/cilium/cilium/pull/13259, feel free to correct if I am mistaken!