Cilium: Ensure `contrib/scripts/lock-check.sh` runs as a precheck and as a GitHub Action

[christarazi]

This would eliminate PRs like this in the future, and provide quicker feedback to the offending PR. https://github.com/cilium/cilium/pull/11729

Items:

• [x] Create Makefile target to run this precheck
• [ ] Create a GH Action that runs the above

[joestringer]

For what it's worth, this should be part of a standard make execution, which:
1) All developers should run prior to submission; and
2) We should have a GH action that runs this target.

[tklauser]

FWIW, the script is already invoked as part of the postcheck target:

https://github.com/cilium/cilium/blob/e871f2830d1d6a6705a700b1e56f88c6cea21ceb/Makefile#L507-L512

which in turn is part of the all target (which is the default target if you run make without a specific target):

https://github.com/cilium/cilium/blob/e871f2830d1d6a6705a700b1e56f88c6cea21ceb/Makefile#L130

which leaves me wondering why it only failed in the CI runtime test, but not Travis CI.

[pchaigno]

which leaves me wondering why it only failed in the CI runtime test, but not Travis CI.

Travis CI doesn't do a full make. It only compiles what it needs to run the unprivileged unit tests AFAIK.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.