Cider: Cannot jack into Boot REPLs on Windows.

Created on 7 Sep 2018  路  21Comments  路  Source: clojure-emacs/cider

Expected behavior

cider-jack-in works inside or outside Boot projects. That is, in a directory with build.boot or outside such a directory but with cider-default-repl-command set to "boot".

Actual behavior

On Linux this works on recent versions of Cider. On Windows it fails with the following trace.

Are you sure you want to run `cider-jack-in' without a Clojure project? (y or n) y
[nREPL] Starting server via "c:/Users/jmacdonald/local/boot/boot.exe" -i "(require 'cider.tasks)" -d "org.clojure/tools.nrepl:0.2.13" -d "cider/cider-nrepl:0.18.0" cider.tasks/add-middleware -m "cider.nrepl/cider-middleware" cider.tasks/nrepl-server -b :: wait...
error in process sentinel: nrepl-server-sentinel: Could not start nREPL server: Classpath conflict: org.clojure/clojure version 1.10.0-alpha7 already loaded, NOT loading version 1.2.0
                              java.lang.Thread.run                     
java.util.concurrent.ThreadPoolExecutor$Worker.run                     
 java.util.concurrent.ThreadPoolExecutor.runWorker                     
               java.util.concurrent.FutureTask.run                     
                                               ...                     
               clojure.core/binding-conveyor-fn/fn       core.clj: 2022
                                 boot.core/boot/fn       core.clj: 1032
                               boot.core/run-tasks       core.clj: 1022
                      cider.tasks/eval224/fn/fn/fn      tasks.clj:   33
                                               ...                     
                      cider-nrepl.main/start-nrepl       main.clj:   54
                    cider-nrepl.main/build-handler       main.clj:   33
                        cider-nrepl.main/->mw-list       main.clj:   29
                                 clojure.core/into       core.clj: 6844
                            clojure.core/transduce       core.clj: 6829
                       clojure.core.protocols/fn/G  protocols.clj:   13
                         clojure.core.protocols/fn  protocols.clj:   75
                 clojure.core.protocols/seq-reduce  protocols.clj:   31
                       clojure.core.protocols/fn/G  protocols.clj:   19
                         clojure.core.protocols/fn  protocols.clj:  136
                                               ...                     
                            clojure.core/map/fn/fn       core.clj: 2734
                               clojure.core/symbol       core.clj:  579
java.lang.ClassCastException: boot.repl$disable_exception_colors cannot be cast to java.lang.String
  clojure.lang.ExceptionInfo: boot.repl$disable_exception_colors cannot be cast to java.lang.String
    line: 5

error in process sentinel: Could not start nREPL server: Classpath conflict: org.clojure/clojure version 1.10.0-alpha7 already loaded, NOT loading version 1.2.0
                              java.lang.Thread.run                     
java.util.concurrent.ThreadPoolExecutor$Worker.run                     
 java.util.concurrent.ThreadPoolExecutor.runWorker                     
               java.util.concurrent.FutureTask.run                     
                                               ...                     
               clojure.core/binding-conveyor-fn/fn       core.clj: 2022
                                 boot.core/boot/fn       core.clj: 1032
                               boot.core/run-tasks       core.clj: 1022
                      cider.tasks/eval224/fn/fn/fn      tasks.clj:   33
                                               ...                     
                      cider-nrepl.main/start-nrepl       main.clj:   54
                    cider-nrepl.main/build-handler       main.clj:   33
                        cider-nrepl.main/->mw-list       main.clj:   29
                                 clojure.core/into       core.clj: 6844
                            clojure.core/transduce       core.clj: 6829
                       clojure.core.protocols/fn/G  protocols.clj:   13
                         clojure.core.protocols/fn  protocols.clj:   75
                 clojure.core.protocols/seq-reduce  protocols.clj:   31
                       clojure.core.protocols/fn/G  protocols.clj:   19
                         clojure.core.protocols/fn  protocols.clj:  136
                                               ...                     
                            clojure.core/map/fn/fn       core.clj: 2734
                               clojure.core/symbol       core.clj:  579
java.lang.ClassCastException: boot.repl$disable_exception_colors cannot be cast to java.lang.String
  clojure.lang.ExceptionInfo: boot.repl$disable_exception_colors cannot be cast to java.lang.String
    line: 5

Steps to reproduce the problem

(setf cider-default-repl-command "boot")

M-x cider-jack-in

Environment & Version information

CIDER version information

REPL won't launch, but I'm using a version tagged 20180903.1611. It corresponds to commit 8996e699ae7dd140a9f74219940e2e30ff213fd9

Lein/Boot version

~/.boot/boot.properties as below. (The same errors occur with other versions of Boot and Clojure.)

#http://boot-clj.com
#Thu Sep 06 09:04:38 CDT 2018
BOOT_CLOJURE_NAME=org.clojure/clojure
BOOT_VERSION=2.8.1
BOOT_CLOJURE_VERSION=1.10.0-alpha7

Emacs version

GNU Emacs 26.1 (build 1, x86_64-w64-mingw32) of 2018-05-29

From the emax64 project.

Operating system

Windows 7.

bug stale
Source
picture jaccarmac

Most helpful comment

As a workaround, you could add
BOOT_COLOR=1 to your ~/.boot/boot.properties file
cider-jack-in works for me after doing that

picture finalpatch on 5 Nov 2018
👍2

All 21 comments

Is there a way for you to see where is this dependency on Clojure 1.2 coming from? Might be from the default injection of nREPl 0.2.13, which I should probably remove now that nREPL 0.4 is here.

bbatsov picture bbatsov on 10 Sep 2018

The 1.2 dependency is from nREPL. At least, those errors disappear when removing the dependency from the Boot invocation (boot -i "(require 'cider.tasks)" -d cider/cider-nrepl\:0.18.0 cider.tasks/add-middleware -m cider.nrepl/cider-middleware cider.tasks/nrepl-server -b :: wait). Note that the Boot REPL task includes its own dependency on nREPL but excludes Clojure.

Errors remain, however. I believe the classpath conflict is a red herring. After a little investigation, I can duplicate the error outside of Windows with boot -C -i "(require 'cider.tasks)" -d cider/cider-nrepl\:0.18.0 cider.tasks/add-middleware -m cider.nrepl/cider-middleware cider.tasks/nrepl-server -b :: wait. This eliminates the classpath conflict but also disables colored output explicitly with -C.

jaccarmac picture jaccarmac on 11 Sep 2018

->mw-list seems to be trying to convert disable-exception-colors into a string but for the life of me I can't figure out why.

jaccarmac picture jaccarmac on 11 Sep 2018

What's disable-exception-colors?

@arichiardi Any insight here, as someone familiar with boot?

bbatsov picture bbatsov on 23 Sep 2018

It's middleware that disables colorization, defined here. It can be triggered on Linux with the -C flag. That's as much as I know, will let others elaborate.

jaccarmac picture jaccarmac on 23 Sep 2018

I see. Might be something wrong in the nrepl-server task in cider-nrepl then. @arichiardi will definitely know more. I'm guessing you won't be having this problem if you update to Boot 2.8.2 and simply change back cider-jack-in to use its server task (as 2.8.2 bundles nREPL 0.4 directly).

bbatsov picture bbatsov on 23 Sep 2018

Uhm i hace no clue, boot was definitely working ootb. Will try to dig more these days, thanks for debugging the problem!

arichiardi picture arichiardi on 23 Sep 2018

Which server task are you referring to? Installed 2.8.2 but the command from above (with -C) still fails for me. It's a minor inconvenience as the REPL still starts and I can connect to it.

jaccarmac picture jaccarmac on 23 Sep 2018

See cider-boot-parameters and change its value to "server -b :: wait". Your stacktrace implies that the bug is in the nrepl-server boot task, so I assume that if you sidestep it things will work for you.

bbatsov picture bbatsov on 23 Sep 2018

I'm getting no such task with those parameters.

jaccarmac picture jaccarmac on 23 Sep 2018

Ops, my bad. It's repl -b :: wait.

bbatsov picture bbatsov on 23 Sep 2018

Yep, that works. On 2.8.1 as well.

jaccarmac picture jaccarmac on 24 Sep 2018

True, but then you'll end up using the legacy nREPL, which I would not recommend at this point. Anyways, we've confirmed for a fact that there's a bug in the custom nrepl-server task. Hopefully @arichiardi will sort this out quickly.

bbatsov picture bbatsov on 24 Sep 2018
👍1

Eh, the only hint I can give without inspecting more is that that particular middleware is ^:private.
My spider senses tell me that that my be the reason. Hopefully I will have time soon for another look.

arichiardi picture arichiardi on 24 Sep 2018
👍1

As a workaround, you could add
BOOT_COLOR=1 to your ~/.boot/boot.properties file
cider-jack-in works for me after doing that

finalpatch picture finalpatch on 5 Nov 2018
👍2

I think I've figured this one out:

  1. If you're using windows or have set the BOOT_COLOR env var to something other than 1, true, or yes (see https://github.com/boot-clj/boot/blob/master/boot/pod/src/boot/util.clj#L45) then boot adds the middleware boot.repl/disable-exception-colors to boot.repl/*default-middleware* . It adds the function itself - not a symbol, var, string, or something else representing the middleware
  2. cider.tasks/nrepl-server passes the value of boot.repl/*default-middleware* to cider.nrepl/start-nrepl
  3. However, cider.nrepl/start-nrepl expects vars or strings, not functions
flyingmachine picture flyingmachine on 21 Mar 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding!

stale[bot] picture stale[bot] on 8 May 2019

@flyingmachine Great analysis!

Not sure where exactly we should fix this, but keep in mind that we're no longer using cider.nrepl/start-nrepl (this was push to nREPL itself). The old ns in cider-nrepl should be removed.

bbatsov picture bbatsov on 12 May 2019

Now the question remains where exactly should this be fixed - on boot's side or on nREPL side? I don't really have a strong preference, but changing this on Boot's end seems more reasonable to me.

bbatsov picture bbatsov on 15 May 2019
👍1

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contribution and understanding!

stale[bot] picture stale[bot] on 13 Aug 2019

This issues been automatically closed due to lack of activity. Feel free to re-open it if you ever come back to it.

stale[bot] picture stale[bot] on 12 Sep 2019
Was this page helpful?
0 / 5 - 0 ratings

Related issues

carbohydratesn picture carbohydratesn  路  6Comments
lilactown picture lilactown  路  5Comments
mwfogleman picture mwfogleman  路  3Comments
crocket picture crocket  路  6Comments
oskarkv picture oskarkv  路  5Comments