Cht-core: Missing translation "state.duplicated"

Created on 7 May 2020  路  5Comments  路  Source: medic/cht-core

Describe the bug
Missing translation for state.duplicate, so the key appears in the app for messages on reports.

To Reproduce
You can try to get this state to occur on a report's messages, but simpler to just look for the translation in the App Management page.

  1. Go to App Management page
  2. Click on Display and then go to Translations tab
  3. Search for state.duplicate
  4. See that it is missing.

Expected behavior
Should show the label "duplicate", not key itself.

Screenshots

Environment

  • Instance: local
  • Browser: Chrome
  • Client platform: Windows
  • App: webapp
  • Version: 6291-case-id branch, which is somewhere between 3.8 and 3.9.

Additional context
This was meant to be solved in #6208, but master doesn't have state.duplicate, and it is not in POEditor. Quicklink to our documentation on translations process.

2 - Medium Bug

All 5 comments

Could you tell why that happened? Was it overwritten accidentally because it wasn't in POEditor so the alphabetised export didn't include it?

It's possible the translations were imported to POE as part of the pre-release process, then the key was added, then they were exported from POE just before release. Release documentation: https://github.com/medic/cht-core/blob/master/.github/ISSUE_TEMPLATE/z_release_major.md

Maybe we should update the process so that immediately before exporting you import again to make sure none are missed.

Works well! Passes AT, ready to merge.

Before and After



The missing case_id translation is expected, given that the separate branches haven't been merged into master yet.

Merged.

Was this page helpful?
0 / 5 - 0 ratings