Chokidar: Update upath version to fix vulnerability warning

Created on 12 Feb 2018  路  6Comments  路  Source: paulmillr/chokidar

After running a scan with Retire.js I got a warning that underscore.string uses a vulnerable jQuery version for some of its tests.

I looked around a bit and because this is only in a test file the vulnerability is not dangerous for end-users. But it would be nice to not scare other developers :)

upath fixed the issue by updating to the latest version of underscore.string in v1.0.1. So by updating upath to v1.0.1 or higher the vulnerability warning should be fixed.

I can submit a PR to change the upath version in package.json but I'm not 100% confident that the change will be bug-free as I'm not familiar with the codebase. If any of the maintainers could have look at it, that would be great.

Most helpful comment

Just published 2.0.2

All 6 comments

This was resolved by #679. I hadn't been planning on it, but I guess I'll publish a patch update to resolve the concern you're raising.

Now that upath is allowed to update in package.json (^1.0.0 instead of 1.0.0), could you please publish a Chokidar release, so that NodeJS >7 is supported.
See:
https://github.com/paulmillr/chokidar/pull/679#issuecomment-365436112

Follow-up: ah, it turns out that --engine-strict can default to true in some cases!
mkdir ChokidarTest && cd ChokidarTest && npm init --yes && npm install chokidar --engine-strict=false
=> okay.
By forcing --engine-strict to false, I should be able to get around this issue.

Just published 2.0.2

Yep, npm install* now works (without --engine-strict=false), thanks for v2.0.2 :)

(* rm -rf node_modules && rm package-lock.json && npm install)

Can confirm that the problem is fixed for me as well. Chokidar was installed through nodemon for me, so I just deleted and re-added it:

yarn remove nodemon
yarn add nodemon
Was this page helpful?
0 / 5 - 0 ratings

Related issues

drsavant-pub picture drsavant-pub  路  9Comments

yebrahim picture yebrahim  路  4Comments

rcarmich picture rcarmich  路  4Comments

xsq007 picture xsq007  路  6Comments

j-fliegenschmidt picture j-fliegenschmidt  路  6Comments