Choices: unhighlightAll in Click handler causes click performance issue on large lists.

[jchamb]

If working with a large chosen list (2000+ items), unhighlightAll is called for every click on the page when the select is inactive. It causes very noticeable click performance delays.

Didn't dig to far to see why it is called there, butIi didn't notice any issues with the select after i removed it form the click handler.

[jshjohnson]

@jchamb Could you provide a js fiddle please highlighting the problem please?

[jchamb]

I actually can't get it to reproduce in an ultra basic fiddle. Admin it's being used in is also using some pjax binding, maybe two things compounding. I took a look at the source and see you have a check wrapped around it in the source.

As I mentioned above I removed the
&&this.unhighlightAll()
in the minified bundle and the problem went away. That hack is good enough to take care of my issue so i'm gonna close this.

[martijnhartlief]

I was running into the same issue where I have over 9000 items.

Changing an input that is not Choices triggers the slowdown, so i think the click handler listens to all input elements instead of the one it's bound to.

Like @jchamb suggested, removing &&this.unhighlightAll() from the minified version removes the slowdown.

[abarrak]

@jchamb I tried to reomve all highlightAll() and unhighlightAll() but the green box and highlight functionality still exist, and the slowness still occur.