Chocolatey-coreteampackages: (putty.install) Iinstalls but Choco shows error code 1603

[pauby]

Expected Behavior

Package should install without any error being shown.

Current Behavior

Package shows this error on install:

ERROR: Running ["C:\WINDOWS\System32\msiexec.exe" /i "C:\ProgramData\chocolatey\lib\putty.install\tools\putty-64bit-0.70
-installer.msi" /quiet] was not successful. Exit code was '1603'. See log for possible error messages.
The upgrade of putty.install was NOT successful.
Error while running 'C:\ProgramData\chocolatey\lib\putty.install\tools\chocolateyInstall.ps1'.
See log for details.

Possible Solution

Add 1603 to valid exit codes.

Steps to Reproduce (for bugs)

Install the package.

[pauby]

PR closed so closing issue.

[AdmiringWorm]

Reopened as it deserves to be looked into why the installer returns the error code.

[pauby]

Thsi was on a new laptop I was setting up so when I get some time I will pull it out and get the Choco logs from it.

[AdmiringWorm]

Adding my latest comment from the PR #850 so we don't have to jump back and forth:

so I will have to dig it back out and go through the logs. Will also run the install again with the switches you asked for and post them here.

Unfortunately I don't believe the chocolatey logs will be useful in this case, but the logs from the msi installer would be useful (msi installers probably logs to a file by default, but I have no idea where 😢)

EDIT:
I plan to go through all of the packages here in this repository to enable logging to a specific file by default (including this one) (same with inno setup installers as well).

[pauby]

I plan to go through all of the packages here in this repository to enable logging to a specific file by default (including this one) (same with inno setup installers as well).

@AdmiringWorm That is a very good idea. And it's something I will look at doing with my own packages. Logging the install to the chocolatey package folder.

I have so far tried 5 times to force the putty.install package install, uninstall and also with rebooting in between and sods law it installs every time without error.

[AdmiringWorm]

@pauby I was rather thinking of logging it to the package cache directory, similiar to how the silent args are used in the default template for msi installs.

silentArgs    = "/qn /norestart /l*v `"$($env:TEMP)\$($packageName).$($env:chocolateyPackageVersion).MsiInstall.log`""

I have so far tried 5 times to force the putty.install package install, uninstall and also with rebooting in between and sods law it installs every time without error.

Isn't that typical XD, it never happens when we want it to.
Lets still keep this issue open in case it happens again in the future, I don't really want to make any changes until we have determined the underlying issue for the 1603 error (could be an update missing, a reboot is required or many other things I believe).

[majkinetor]

@pauby

Until this is resolved, you could use kitty package or putty.portable.

[pauby]

The package does install @majkinetor - it did exit with the 1603 error code though. The first time.

On the 5 subsequent install / uninstalls (to try and reproduce the error) it also installed with, sods law, no error code.

So it is installed and worked. I'm sure I tried kitty before and went back to the old favourite.

[majkinetor]

The problem with 1603 is that it generally can happen on different place next time, where it might actually be fatal.

I'm sure I tried kitty before and went back to the old favourite.

Strange, given the kitty just adds stuff to putty, many stuff that enable non-interactive use and ability to use password rather then SSH key.

[majkinetor]

@pauby

I now added logging part and pushed package fix. When you encounter this problem again, please attach a complete install.log file.

Log is at: $Env:TEMP\chocolatey\$Env:ChocolateyPackageName\$Env:ChocolateyPackageVersion

Package: https://chocolatey.org/packages/putty.install/0.70.0.20171219

[pauby]

Thanks. If it happens again I will do that.