Choco: AutoUninstaller - Captures registry snapshot escaping quotes - unable to find path for uninstall

[externl]

What You Are Seeing?

git.install auto uninstaller can't find the git uninstaller even though it exists. The path seems to have bogus quotes.

 Skipping auto uninstaller - The uninstaller file no longer exists. ""C:\Program Files\Git\unins000.exe""

What is Expected?

The git uninstall should run and git should be uninstalled.

How Did You Get This To Happen? (Steps to Reproduce)

choco install git.install
choco uninstall git.install

Output Log

git.install v2.17.0
 Running auto uninstaller...
 Skipping auto uninstaller - The uninstaller file no longer exists. ""C:\Program Files\Git\unins000.exe""
 git.install has been successfully uninstalled.

However, the file actually exists.

C:\Windows\system32>dir "C:\Program Files\Git"
 Volume in drive C is Windows 10
 Volume Serial Number is 6EFD-B73A

 Directory of C:\Program Files\Git

04/17/2018  05:08 PM    <DIR>          .
04/17/2018  05:08 PM    <DIR>          ..
04/17/2018  05:07 PM    <DIR>          bin
04/17/2018  05:08 PM    <DIR>          cmd
04/17/2018  05:08 PM    <DIR>          dev
04/17/2018  05:08 PM    <DIR>          etc
04/03/2018  11:29 AM           148,248 git-bash.exe
04/03/2018  11:29 AM           147,224 git-cmd.exe
03/19/2018  10:17 AM            18,765 LICENSE.txt
04/17/2018  05:07 PM    <DIR>          mingw64
04/03/2018  11:38 AM           128,430 ReleaseNotes.html
04/17/2018  05:07 PM    <DIR>          tmp
04/17/2018  05:08 PM         1,085,186 unins000.dat
04/17/2018  05:07 PM         1,289,880 unins000.exe
04/17/2018  05:08 PM            22,795 unins000.msg
04/17/2018  05:08 PM    <DIR>          usr
               7 File(s)      2,840,528 bytes
               9 Dir(s)  160,067,874,816 bytes free

[ferventcoder]

Full log please.

[ferventcoder]

@gep13 do you think this might have something to do with our changes for 0.10.9 where we are converting values with escaping bad XML?

[ferventcoder]

1534

[externl]

@ferventcoder Do you still require a full output of an uninstall?

[AdmiringWorm]

@ferventcoder I was able to reproduce this on the choco environment with 0.10.10.

I added a gist with both install and uninstall log, as well as the detected registry xml (which I believe is the source of the problem here).

https://gist.github.com/AdmiringWorm/61e34d79306b81c7d8b60bffadf6d9cd

[AdmiringWorm]

Basically it seems the detection is escaping quotes when it shouldn't.

[ferventcoder]

We think this was caused by #1505.

[AeliusSaionji]

This same thing is happening to me for just about every package using an auto uninstaller. Perhaps this is a red herring: I'm using JPN locale.

[ferventcoder]

It's not that, it's happening likely for everyone - so we're bumping the priority of this up.