Chi: JSON response

[hmgle]

Now it is not very comfortable to send a JSON response:

type Foo struct {
    Bar string
}

func foo(w http.ResponseWriter, r *http.Request) {
    w.Header().Set("Content-Type", "application/json")

    b, err := json.Marshal(&Foo{Bar: "bar"})
    if err != nil {
        http.Error(w, err.Error(), 422)
        return
    }
    w.WriteHeader(http.StatusOK)
    w.Write(b)
}

What about add the JSON(code int, obj interface{}) method like gin or echo?

[pkieltyka]

hi @hmgle I'd prefer to keep chi as just a router. If you need a responder, I suggest to use https://github.com/unrolled/render which works just fine with chi.

your code will look like:

import renderPkg "github.com/unrolled/render"

var render *render.Render

func init() {
  render = renderPkg.New() // pass options if you want
}

func x() http.Handler {
  r := chi.New()
  r.Get("/", handler)
}

func handler(ctx context.Context, w http.ResponseWriter, r *http.Request) {
  // processing..
  render.JSON(w, 200, responseObj)
}

another suggestion, is wrap the unrolled/render package by making your own "render" package that is a part of your project, and set defaults there so its setup to use across packages.

[pkieltyka]

The goals of chi are to stay minimal, allow full control without limitation of possibility or productivity. I guess the gap right now is that chi doesn't provide every library out of the box, you're expected to make your own choices for something like the responder. I will update the example to show how to wrap your own render responder.

[pkieltyka]

@hmgle here you go https://github.com/pressly/chi/blob/master/_examples/rest/main.go
and
https://github.com/pressly/chi/blob/master/_examples/rest/render/render.go

[hmgle]

Got it~ It looks elegant.

[hugows]

Was the example linked in https://github.com/pressly/chi/blob/master/_examples/rest/render/render.go integrated into rest/main.go?

[pkieltyka]

@hugows yes exactly. Its now at: https://github.com/go-chi/chi/blob/master/_examples/rest/main.go

[hugows]

So I'd like to understand if you prefer something like:

"render.RenderList(w, r, NewArticleListResponse(articles))

instead of something like unrolled/render does, based on interface{}...

Thanks for chi btw! :)