Cheerio: empty attributes are appended with =""

[kfuchs]

Original element:

<div class="user-menu" dropdown-toggle>

After using cheerio on file:

<div class="user-menu" dropdown-toggle="">

For some reason cheerio is appending all empty attributes with =""

[pyhedgehog]

XHTML standard defines attr=attr for empty attributes.

[kfuchs]

Anyway to turn this off?

[fb55]

IMHO this should become the default behavior in non-XML mode. PRs for the dom-serializer module very appreciated.

[etiktin]

@fb55, I sent a PR to fix this issue.
Please review and merge

[ghetolay]

Well I have the opposite problem :)
I'm working with xhtml and default="" is converted into default.

Problem come from that line :

if (!value && booleanAttributes[key]){

default is part of the booleanAttributes array.
So I guess we should check about xmlMode sooner.

Do you want a pull request ?

[timaschew]

since dom-serializer ist not published to npm and cheerio is not updated to that new version yet, this issue is not fixed

[timaschew]

Please reopen this issue, it's still broken!

[arthurevans]

Any chance of a new release of dom-serializer to fix this issue?

[mankins]

Maybe interested in https://github.com/cheeriojs/dom-serializer/pull/72