Che: Icons for tabs are not displayed

[dmytro-ndp]

Describe the bug

Icons are absent for different kinds of tabs: task tab, terminal tab, editor tab.
Please see https://github.com/eclipse/che/issues/17978#issuecomment-700739292

The issue is blocking an update Devfile E2E tests and GitSSH flow E2E tests #17973.

Che version

• [ ] latest
• [x] nightly
• [ ] other: please specify

Steps to reproduce

1. Start nightly Eclipse Che
2. Create and open Java maven workspace
3. Open any file, terminal or run a task

Expected behavior

A tab contains the corresponding icon:

Actual wrong result

There are no icons for tabs:

Runtime

• [ ] kubernetes (include output of kubectl version)
• [ ] Openshift (include output of oc version)
• [x] minikube 1.1.1
• [ ] minishift (include output of minishift version and oc version)
• [ ] docker-desktop + K8S (include output of docker version and kubectl version)
• [ ] other: (please specify)

Screenshots

Installation method

• [x] chectl
  
  
  
  • provide a full command that was used to deploy Eclipse Che (including the output)
  
  
  • provide an output of chectl version command
  
  
• [ ] OperatorHub
• [ ] I don't know

Environment

• [ ] my computer
  
  
  
  • [ ] Windows
  
  
  • [ ] Linux
  
  
  • [ ] macOS
  
  
• [ ] Cloud
  
  
  
  • [ ] Amazon
  
  
  • [ ] Azure
  
  
  • [ ] GCE
  
  
  • [ ] other (please specify)
  
  
• [ ] other: please specify

Eclipse Che Logs

Additional context

[RomanNikitenko]

Tested on che-dogfooding instance - can not reproduce it.

[azatsarynnyy]

@dmytro-ndp is it stable reproducible or does it requires some specific environment, devfile, etc.

[azatsarynnyy]

@dmytro-ndp It seems we were modifying the issue labels at the same time
That's why it shows I removed the blocker from it. It's done not on purpose :slightly_smiling_face:
Feel free to re-check the labels and correct it if needed.

[RomanNikitenko]

Tested on https://che.openshift.io/ - can not reproduce the bug

[azatsarynnyy]

@dmytro-ndp is it stable reproducible or does it requires some specific environment, devfile, etc.

@dmytro-ndp could you also attach the screenshot of Help>About dialog to check what version is used in your case?

[dmytro-ndp]

@azatsarynnyy, @RomanNikitenko: I also can't reproduce it on che.openshift.io in workpsace having changes from corresponding PR https://che.openshift.io/f/?url=https://raw.githubusercontent.com/chepullreq4/pr-check-files/master/che-theia/pr-823/simple/che-theia-maven-devfile.yaml

[dmytro-ndp]

@azatsarynnyy

@dmytro-ndp could you also attach the screenshot of Help>About dialog to check what version is used in your case?

It's nightly version of che-theia: quay.io/eclipse/che-theia@sha256:3be78bf018b54eb6a8cf518a85cda95973cb831652819003e43c234116f3aa05

[dmytro-ndp]

@RomanNikitenko, @azatsarynnyy: I have reproduced an issue on Eclipse Che nightly instance on QE OCP https://che-nightly-che.apps.ocp45.crw-qe.com/dashboard/#/ide/admin/apache-camel-k-sxln1?tab=getStarted

[RomanNikitenko]

@dmytro-ndp
Nice!

But from your screenshot I see that a task was not started at all
I tried your link and see that behavior as well

I thought that E2E tests were failed because they were waiting successfully completed task https://github.com/eclipse/che/issues/17973
isn't it?

[RomanNikitenko]

@dmytro-ndp
I played a little with the instance that you provided and can reproduce the issue for started tasks and different statuses.
So, looks like we can use this instance to debug the corresponding code and fix the issue.

Thank you very much for your help, Dmytro!

[dmytro-ndp]

@RomanNikitenko: you are right about the test.
Actually, the issue is about task status icon, which isn't been shown doesn't matter if it's successful, error, or in-progress task:

[RomanNikitenko]

Actually, the issue is about task status icon, which isn't been shown doesn't matter if it's successful, error, or in-progress task

I understand, but technically the causes of the problems are different for already started task and not started at all.
To fix E2E tests it was important to reproduce the issue for already started tasks.
That's why I asked about it.

As I mentioned above https://github.com/eclipse/che/issues/17978#issuecomment-700132044 I can reproduce the issue using instance that you provided and we can use this one to debug the corresponding code and fix the issue.

[RomanNikitenko]

@dmytro-ndp
For the instance that you provided I see that icons are absent for different kinds of tabs: task tab, terminal tab, editor tab. So the issue is more global.

Expected:

Actual:

btw: you can see it on your screenshots as well, here for example: https://github.com/eclipse/che/issues/17978#issuecomment-700132638

[dmytro-ndp]

@RomanNikitenko: good catch, thank you!