Che: Not able to open workspace with direct link

[skabashnyuk]

Describe the bug

I was no able to open workspace with a direct like this https://che-che.apps-crc.testing/admin/gogo

Che version

• [ ] latest
• [x] nightly
• [ ] other: please specify

Steps to reproduce

1. Create a workspace.
2. Open a direct link in a separate tab of the browser.
3. The workspace is not loaded correctly.

Expected behavior

Workspace loaded correctly.

Runtime

• [ ] kubernetes (include output of kubectl version)
• [X] Openshift (include output of oc version)
• [ ] minikube (include output of minikube version and kubectl version)
• [ ] minishift (include output of minishift version and oc version)
• [ ] docker-desktop + K8S (include output of docker version and kubectl version)
• [ ] other: (please specify)

Screenshots

Installation method

• [x] chectl
• [ ] che-operator
• [ ] minishift-addon
• [ ] I don't know

Environment

• [ ] my computer
  
  
  
  • [ ] Windows
  
  
  • [ ] Linux
  
  
  • [x] macOS
  
  
• [ ] Cloud
  
  
  
  • [ ] Amazon
  
  
  • [ ] Azure
  
  
  • [ ] GCE
  
  
  • [ ] other (please specify)
  
  
• [ ] other: please specify

Additional context

[sleshchenko]

This is an error that comes from https://github.com/eclipse/che/blob/79c6ec0703fb5c00458e2fa00b4df9f586c0c5a9/assembly/assembly-root-war/src/main/webapp/_app/IDE.html#L210

[skabashnyuk]

@sleshchenko do you have an idea how to fix it?

[akurinnoy]

@skabashnyuk it fails there because String doesn't have the contains method (was removed some time ago AFAIK). The best way is to use indexOf() which is supported by all browsers.

[skabashnyuk]

it fails there because String doesn't have the contains method

[sleshchenko]

I suppose we're able easily to configure tomcat to redirect ${namespace}/${workspaceName} -> workspace-loader/${namespace}/${workspaceName}, but not sure if we need it. @skabashnyuk WDYT?

[skabashnyuk]

I suppose we're able easily to configure tomcat to redirect ${namespace}/${workspaceName} -> workspace-loader/${namespace}/${workspaceName}, but not sure if we need it. @skabashnyuk

We could try. I assume that might be some edge cases. It's for sure will take more time then https://github.com/eclipse/che/pull/16127. Thanks, guys for this pr.