Che: Adaptation for tasks is required

Created on 1 Aug 2019  路  4Comments  路  Source: eclipse/che

The bug is relevant for eclipse/che-theia:next, so for master branch assembly.

Describe the bug

After alignment theia tasks with vs code behavior we need some adaptation on our side.

I still can run che tasks, but at least:

  • configure task action is not working
  • detected tasks are displayed in different way
  • after page refreshing Terminal -> Run Task menu action is triggered only on second click
    Please see the video: https://youtu.be/DXe_R-ubxa8

I tested it on theia side and it works well.
Looks like some changes for task definitions are required on our side.

Che version

  • [ ] latest
  • [ ] nightly
  • [x] other: eclipse/che-theia:next

Steps to reproduce

  1. Add to a devfile the section:
- 
    alias: theia-editor
    reference: >-
      https://raw.githubusercontent.com/eclipse/che-plugin-registry/master/v3/plugins/eclipse/che-theia/next/meta.yaml
    type: cheEditor
  1. Start a workspace from the devfile
  2. Go to Terminal -> Run task
    You can see that for detected tasks the type of the task is used, not source (for example, shell instead of npm )
  3. Try to configure a detected task - click on cog icon - the configuration should be copied to tasks.json file, but nothing is happen.

Expected behavior

  • ability to configure a detected tasks
  • source field is used for displaying of detected tasks
  • after page refreshing Terminal -> Run Task menu action is triggered on first click

Runtime

  • [ ] kubernetes (include output of kubectl version)
  • [ ] Openshift (include output of oc version)
  • [x] minikube v1.0.0
  • [ ] minishift (include output of minishift version and oc version)
  • [ ] docker-desktop + K8S (include output of docker version and kubectl version)
  • [ ] other: (please specify)

Screenshots

Actual displaying
actual

Expected displaying
expected

Installation method

  • [x] chectl chectl/0.0.2-6d3894f linux-x64 node-v10.4.1
  • [ ] che-operator
  • [ ] minishift-addon
  • [ ] I don't know

Environment

  • [ ] my computer

    • [ ] Windows

    • [x] Linux

    • [ ] macOS

  • [ ] Cloud

    • [ ] Amazon

    • [ ] Azure

    • [ ] GCE

    • [ ] other (please specify)

  • [ ] other: please specify

Additional context

areeditoche-theia kinbug severitP1

Most helpful comment

@slemeur moved to 7.1.0 for now

All 4 comments

cc @slemeur I think we need to take it for 7.1
WDYT?

@slemeur moved to 7.1.0 for now

I added to the description of the issue one more use case related to Terminal -> Run Task menu.
The video for the case is available as well.

The bug was caused by last changes in master branch of theia repo. I can not reproduce it for theia project, so some changes are required on che-theia side.

I investigated the issue: the bugs related to detected tasks are caused by using 7.0.0-next version of eclipse/che-theia-endpoint-runtime for remote plugins. 7.0.0-next version doesn't contain activateByEvent logic.

So the issue is fixed by using next version of eclipse/che-theia-endpoint-runtime for remote plugins.

Was this page helpful?
0 / 5 - 0 ratings