Che: Add eslint to Typescript language support plugins

Created on 30 Jul 2019  路  13Comments  路  Source: eclipse/che

When building theia, there are numerous rules from tslint being enforced, however, even though there is a vs code extensions for tslint, it's not included in our typescript support (https://marketplace.visualstudio.com/items?itemName=ms-vscode.vscode-typescript-tslint-plugin)
This leads to many cases where we only find build problems when running the command line build.

We should find a way to offer tslint support for Che.

arelanguages areplugins kinenhancement

Most helpful comment

ES Lint 2.1.1 was added to Che plugin registry with https://github.com/eclipse/che-plugin-registry/pull/687

All 13 comments

Since there is no vsix in the release, we need to host the file somewhere (in redhat-developer or so).

Turns out this one is blocked by: Plugins should have ability to spawn processes #15087

Issues go stale after 180 days of inactivity. lifecycle/stale issues rot after an additional 7 days of inactivity and eventually close.

Mark the issue as fresh with /remove-lifecycle stale in a new comment.

If this issue is safe to close now please do so.

Moderators: Add lifecycle/frozen label to avoid stale mode.

/remove-lifecycle stale

Thank you for working on this issue.
I'd like to add a '+1' to the request for TsLint, we are hearing from CRW users that have the same request.

just a FYI but tslint is deprecated over eslint now

I've renamed the issue, instead of tslint we will be providing the eslint extension: https://marketplace.visualstudio.com/items?itemName=dbaeumer.vscode-eslint

ES Lint is already introduced to built-ins plugin with PR https://github.com/eclipse/che-theia/pull/902
To test how it works see https://github.com/eclipse/che-plugin-registry/pull/687#issuecomment-726183847

it should be a built-in extension
it needs to be removed by default and added as separate extension

It's a built-in in theia, why remove it in che-theia and make more work for ourselves to have it as a separate plugin?

I propose to look at it from a bit different perspective :slightly_smiling_face: :
why do we need to launch JavaScript linting extension with every Che Workspace no matter what stack it's based on - Java, go, Python, PHP, etc.?

Fair enough. @vitaliy-guliy, this one is back on your plate.

ES Lint 2.1.1 was added to Che plugin registry with https://github.com/eclipse/che-plugin-registry/pull/687

Was this page helpful?
0 / 5 - 0 ratings