Che: Add support for C/C++

[slemeur]

Description

We should have support for C/C++ out of the box in Eclipse Che.

The work would consist in integrating existing C/C++ language server and provide default stack for it.

• [x] Ensure VS Code extensions [1] works with local Theia
  
  
  
  • [x] https://github.com/theia-ide/theia/pull/5795
  
  
  • [x] https://github.com/theia-ide/theia/pull/5803
  
  
• [x] Compare [3] [4] with VS Code extension [1] https://github.com/eclipse/che/issues/13698#issuecomment-515403416
• [x] Build and host vsix package for [3] [4] https://github.com/che-incubator/che-cpptools
• [x] dockerfile
  
  
  
  • [x] https://github.com/eclipse/che-theia/pull/401
  
  
• [x] Devfile
  
  
  
  • [x] https://github.com/eclipse/che/issues/14131
  
  
  • [x] https://github.com/eclipse/che-devfile-registry/pull/73
  
  
  • [x] https://github.com/eclipse/che/issues/14290
  
  
  • [x] https://github.com/eclipse/che/issues/14289
  
  
• [x] Che plugin
  
  
  
  • [x] https://github.com/eclipse/che-plugin-registry/pull/197
  
  
• [x] Exclude @theia/cpp extension
  
  
  
  • [x] https://github.com/eclipse/che-theia/pull/396
  
  
• [x] Update Language support troubleshooting document [2]
• [ ] Update getting-started factories
• [x] Go to definition feature doesn't work
  
  
  
  • [x] Theia can't open files located in a sidecar container https://github.com/eclipse/che/issues/13614
  
  

Reference:
[1] https://marketplace.visualstudio.com/items?itemName=ms-vscode.cpptools
[2] https://docs.google.com/document/d/182PBN5LBNTlbhsqqsb5QHg9t5HNK3rSLrnIMPSGjyN0/edit#heading=h.tyhhnnuon2rs
[3] https://github.com/eclipse-cdt/cdt-vscode
[4] https://github.com/eclipse-cdt/cdt-gdb-vscode

[ibuziuk]

@slemeur one of the getting-started [1] factories is C/C++
Are you ok to replace it with Go for Che 7 GA? Once C/C++ support will be in place we would also add a dedicated devfile to the getting-started page

[1] https://www.eclipse.org/che/getting-started/cloud/

[slemeur]

@ibuziuk yep.

[slemeur]

from @ferdaarikan:
We should also reach out to: https://github.com/eclipse-cdt/cdt-vscode and check if they would be interested to publish the CDT VS Code extension to Che.

[tsmaeder]

It's ok to do this after 7.0, but is it something we _need_ to do in the first sprint after 7.0? I imagine we'll have plenty of bugs to fix.

[tsmaeder]

The C++ VS Code extension has the same license problems as the C# one has: we cannot reuse it. This needs analysis, but we'll probably have to package our own plugin. The language server (clangd) does not have licensing problems.

[tolusha]

@tsmaeder @slemeur
eclipse-cdt/cdt-vscode [1] provides the same functionality as VS Code extension [2] but it work in conjunction with two other extensions [3] [4]

[1] https://github.com/eclipse-cdt/cdt-vscode
[2] https://marketplace.visualstudio.com/items?itemName=ms-vscode.cpptools
[3] https://github.com/eclipse-cdt/cdt-gdb-vscode
[4] https://marketplace.visualstudio.com/items?itemName=llvm-vs-code-extensions.vscode-clangd

[slemeur]

And is it possible to package them together?

[tolusha]

I think so.

[tolusha]

@l0rd
Could you pls create a repository in https://github.com/che-incubator/ to put dockerfiles to build and host vsix packages for [1] [2]

For instance che-incubator/che-cpptools

[1] https://github.com/eclipse-cdt/cdt-vscode
[2] https://github.com/eclipse-cdt/cdt-gdb-vscode

[benoitf]

FYI https://github.com/che-incubator/che-cpptools created

[wonjooncho]

Can I ask some question about this issue?
Is there any plan to support LLVM (Clang) in this C++ environment(dockerfile)?

[tolusha]

@wonjooncho
Hello.
There will be two docker containers:

1. custom docker container with tools needed to run C++ plugin: clang g++ gdb
2. development container with g++, gdb: https://registry.centos.org/centos/devtoolset-7-toolchain-centos7/latest

[tolusha]

Here is the devfile for the testing purpose to play with c/c++ tools

apiVersion: 1.0.0
metadata:
  name: cpp
projects:
  -
    name: cpp-hello-world
    source:
      type: git
      location: 'https://github.com/che-samples/cpp-hello-world'
components:
-
  type: chePlugin
  reference: https://raw.githubusercontent.com/tolusha/plugins-registry/master/plugins/tolusha/cpptools/0.1/meta.yaml
  alias: cpp-plugin
  preferences:
    clangd.path: /usr/bin/clangd
    cdt.clangd.binaries.enable: false
-
  type: dockerimage
  alias: cpp-dev
  image: registry.centos.org/centos/devtoolset-7-toolchain-centos7
  command: ['sleep']
  args: ['infinity']
  memoryLimit: 512Mi
  mountSources: true
commands:
  -
    name: build
    actions:
      - type: exec
        component: cpp-dev
        command: g++ -g hello.cpp -o hello.out
        workdir: ${CHE_PROJECTS_ROOT}/cpp-hello-world
  -
    name: debug
    actions:
      - type: vscode-launch
        referenceContent: >
          {
            "version": "0.2.0",
            "configurations": [
                {
                    "type": "gdb",
                    "name": "Debug c++ application",
                    "request": "launch",
                    "program": "/projects/cpp-hello-world/hello.out"
                }
            ]
          }

[kellyhyomin]

@tolusha

When I created a workspace with c/c++ stack I faced the same issue as below screen.

Even if I reload, I keep getting a message to reload.
I used the che-theia, plugin-registry and devfile-registry you updated recently.

I would appreciate it if you would help this issue.

[tolusha]

@kellyhyomin
Unfortunately I can't test the plugin with the latest images due some issues.

1. Regarding its current state, the error above is expected because @theia/cpp extension isn't disabled in the version of Theia that is used for testing purpose. Despite the error the LS should work. Could you try some LS features to check it?

2. clang is installed (it is requirement for plugins to work) in a sidecar container and not in a dev container.

[kellyhyomin]

@tolusha
Thank you for your help.
What version of theia can I use with the @ theia/cpp extension?
Other features, such as the hover function, seem to be working, but the code completion does not work properly.

[tolusha]

It is supposed to use Che c/c++ plugin with the latest version or Eclipse Che (7.1.0-SNAPSHOT) but we have to fix this issue [1] at first
[1] https://github.com/theia-ide/theia/issues/5993

[kellyhyomin]

@tolusha
Thank you for your help.
I am using your devfile.yaml(https://github.com/eclipse/che-devfile-registry/blob/ab/cpp/devfiles/cpp/devfile.yaml) in che 7.1.0 version.
Why build g ++ with cpp-dev terminal rather than building with clang in cpp-plugin terminal?
I want to build with clang.

[tolusha]

@kellyhyomin
I guess that's not a problem.

When you need to create a workspace just add a new component (or replace the existed) in the devfile and set the image with the clang inside. For instance:

  type: dockerimage
  alias: cpp-dev-clang
  image: <some image>
  command: ['sleep']
  args: ['infinity']
  memoryLimit: 512Mi
  mountSources: true