Che: Browser was freeze when running `npm install` in the console.

[monaka]

Reproduction Steps:

1. Setup node environment
2. Get an application contains packages.json via GitHub or somewhere.
3. Run npm install
4. Browser is hang up. Browser's console shows 504 error in ws://.../connect

This is not 100% reproduction.

OS and version:

• Version :5.18.0-SNAPSHOT
• Revision :5231059555dc1838
• Build Time :2017-09-08 13:45:52

Diagnostics:

I suspect the root cause is this NPE.

[sr229]

@monaka I can't reliably reproduce this, my npm exits fine and there was no 504 reported in my end. Probably connection issues?

[monaka]

I don't think the root cause is connection issue.
Traefik report like this.

time="2017-09-10T06:40:22Z" level=warning msg="Error dialing `172.18.0.2:4412`: dial tcp 172.18.0.2:4412: getsockopt: connection timed out" 

Looks the terminal service on dev-machine is down.

[monaka]

I created PR #6205 to show my expectations. Frankly I've not tested that yet. Anyway this will be issue by execution timing.

[bmicklea]

@monaka thanks for the issue and associated PR - it looks like you've found a bug here and we really appreciate the PR. One of the maintainers has already commented on the PR asking you for some feedback - can't wait to see this merged!

[sr229]

@monaka I was able to reproduce the NPE after some trials, so I can confirm this.

[davidwindell]

We've also seen this issue quite a lot, but in our case when we copy a massive amount of files/directories from within a docker image into the workspace

[SkorikSergey]

Is this still an issue?

[davidwindell]

Not for us, resolved with the tree fixes last year

[bmicklea]

Closing as fixed - @monaka if this is still an issue please reopen with details.