Che: Eliminate necessity for the extensions to depend on the IDE App module

Created on 26 Jun 2017  路  5Comments  路  Source: eclipse/che

There are about 30 IDE extensions, in the CHE/Codenvy assemblies, which must depend on the IDE App (che-core-ide-app module) in order to use just a few interfaces/classes. Like org.eclipse.che.ide.CoreLocalizationConstant,
org.eclipse.che.ide.newresource.AbstractNewResourceAction, etc. Having a such dependency really is a bad practice for the IDE extensions.

The goal of this task is to eliminate the necessity for the IDE extensions to depend on the che-core-ide-app module. This may require moving some interfaces/classes from che-core-ide-app to che-core-ide-api or improve IDE API in some way.

kinenhancement targeche6 teaplugins

Most helpful comment

@azatsarynnyy @vparfonov
Let's review and try to find a "golden mean" (not putting a lot of effort).
Indeed, let's do not consider a "refactoring" but be dependent on other module just due to a couple of constants does not look that reasonable.
Thoughts?

All 5 comments

Totally agree, let's clean framework and make a real distinction between framework and app on top.

+1 on this since Che aims for modularization, this is a step forward

@vparfonov what are the state of this issue?

@azatsarynnyy @vparfonov
Let's review and try to find a "golden mean" (not putting a lot of effort).
Indeed, let's do not consider a "refactoring" but be dependent on other module just due to a couple of constants does not look that reasonable.
Thoughts?

Closing as Che 6 editor is no longer under active development

Was this page helpful?
0 / 5 - 0 ratings