Chatterino2: Crash when moving split across windows

Created on 5 Dec 2020  路  4Comments  路  Source: Chatterino/chatterino2

Describe the bug
A bit of a weird one here: if you popup a split, drag that split into another window, then close the popup window, a crash occurs.

To reproduce

  1. Popup a split (via CTRL+N)
  2. From the popup window, drag that split back into another window
  3. Close the window you dragged the split from
  4. Wait for it to crash - opening another tab seems to make this occur quickly

Screenshots
image

Chatterino version
Chatterino Nightly 2.2.3-beta2 (commit 9ebc448bc, ) (self-built)
Chatterino Nightly 2.2.3-beta2 (commit 05aab8684, 22.11.2020)

Operating system
Windows 10 20H2 (OS Build 10942.662)

Additional information
This crash seems to appear in a few different places in code depending on the timing, but these are the two I've been able to capture trying to repro while filing this issue.
image
image
image

bug crash
Source
picture sando

Most helpful comment

Can confirm #2259 fixes the issue. Tried the above example and a few other combinations of manipulating splits across windows, no crashes. :)

picture sando on 6 Dec 2020
👍2

All 4 comments

Cannot reproduce: Windows 10 20H2 | commit a79081f44

alazymeme picture alazymeme on 5 Dec 2020

Can reproduce, looking into this now

pajlada picture pajlada on 6 Dec 2020
❤1

@sando Could you please try this PR out to see if it fixes your issue? https://github.com/Chatterino/chatterino2/pull/2259

pajlada picture pajlada on 6 Dec 2020
👀1

Can confirm #2259 fixes the issue. Tried the above example and a few other combinations of manipulating splits across windows, no crashes. :)

sando picture sando on 6 Dec 2020
👍2
Was this page helpful?
0 / 5 - 0 ratings

Related issues

TETYYS picture TETYYS  路  3Comments
fourtf picture fourtf  路  3Comments
kehlery picture kehlery  路  3Comments
fourtf picture fourtf  路  3Comments
PSlopp picture PSlopp  路  3Comments