Chatterino2: 2nd custom highlight color unchangeable

[AnsonX10]

When clicking the color for the 2nd highlight in the list, the color menu doesn't open. I've experienced it on Linux (KDE) and Windows.

But I do love the new ability to change the color of highlights. Makes them infinitely more useful.

[Mm2PL]

Are you talking about whispers highlights?

[AnsonX10]

Whispers is the 2nd in the list of message highlights, and also doesn't let you change the color (same as "Users" highlight colors). I can't be sure they're related, but it seems coincidental that it also happens to be the 2nd item in the list.

[Mm2PL]

I can open the color menu on the second user highlight (6th item on the list).
What Chatterino version are you running? You can look this up in the About tab of the Settings. I'm looking for the version and commit 🙂

[apa420]

@Mm2PL are you sure? I'm pretty sure there is no code to change whisper color and considering the "color" row for whispers doesn't exist I don't think you can click it (in your image).

[Mm2PL]

@apa420, There is no code for that, you are correct. I said that I can change the second highlight created by the user, which is 6th item on the list counting the highlights not created by the user.

@AnsonX10, I think there may be a misunderstanding here. I have no idea if you wanted to change the color of the whisper highlights or the second highlight you created.

The issue template is there to help describe issues/suggestions clearly to minimize situations like this.

[apa420]

The whisper is the second item in the highlight list.
It makes sense to me.
Well it makes sense with the extra info.

[AnsonX10]

And yes, I am only wanting to change user highlight colors, not whisper colors. (Although that would probably be nice too.)

[apa420]

Ok so every highlighted user except for the 2nd item you can change color for.

[AnsonX10]

Exactly.

Mm2PL said "I can open the color menu on the second user highlight (6th item on the list)."
But that's the message highlight list, not users. There, you can put whatever text you want to highlight.

[Mm2PL]

Can reproduce on Highlighted Users on 359adbce.
Quick guide for people seeing this thread later:

1. Create (or have) at least two User Highlights
2. Attempt to change the Color of the 2nd one
3. Observe that nothing happens, while the expected behavior is to open the color picker.

You can easily go around this bug by adding another highlight and deleting it.

E: Here's a GIF of me reproducing the bug 🙂

[leon-richardt]

Hmm, this "feels" very similar to a bug that was fixed in https://github.com/Chatterino/chatterino2/pull/1522. I will look into it.

[leon-richardt]

Regarding the missing color field in the "Whispers" row: After consulting git blame, it seems like @fourtf commented the relevant code out in 097f4ccb3. Not sure if this was done on purpose (in that case, the code should have been deleted altogether, not just commented out) or on accident. But @fourtf can probably shed some light on that.