Chatterino2: Windows are brought back to life after closing the settings window

[Mm2PL]

Describe the bug

Any popup window that was closed before closing the settings window will appear.

To reproduce

1. Open a popup, like the Search popup.
2. Close it.
3. Open and close settings twice.
4. Observe that the window popped-up again, even though it should have been destroyed.

Screenshots

N/A

Chatterino version

Head is 10692354 + my own patches. Using old Makefile, so Version display is bugged on my build.

Operating system

Ubuntu 20.04.1 LTS

Additional information

Using an emote picker popup (the one brought up using :) with an empty text box can crash, because of an assert. Be careful :).

[leon-richardt]

Cannot reproduce on 359adbce (Arch Linux, i3-gaps).

[Mm2PL]

Very weird 🤔 Could maybe something do to with build flags, since those could be different in our builds?

[leon-richardt]

Potentially. Would you mind providing a GIF of you reproducing the behavior? I might be doing something wrong.

[Mm2PL]

Yeah I can make one ppHop
Here's one:

Update ping FeelsDonkMan @leon-richardt

[leon-richardt]

Tried again, could not reproduce :thinking:

[apa420]

I can't reproduce either on dwm arch and windows 8.1 (Arch is basically newest version and Windows is using an older version )

[pajlada]

stacktrace would be helpful here - not sure if they're automatically collected on asserts but if they're not, just replace the triggered assert with something that would segfault

[Mm2PL]

I couldn't replicate the bug on a fresh Chatterino config. Here's my settings.json stripped from secrets. Gonna make a core dump from this config soon ppHop Something that segfaults didn't produce a core dump on my system.