Chatterino2: Make image uploader warning check for deletion support

Created on 10 Jul 2020 · 4Comments · Source: Chatterino/chatterino2

Why should it be added?

The dialog is very scary:

You are uploading an image to an external server.
You may not be able to remove the image
from the site. Are you okay with this?

What should be added?

If the user has filled out the Deletion link, we should not scare them that they might not be able to delete the image.

I would like to have the text changed to something like this:

You are uploading an image to an external server.
The server seems to have deletion support.
Are you okay with this?

enhancement

Source

Mm2PL

Most helpful comment

I bet you want to have something like "dynamic warning" that would change based on whether we have deletion link specified or not, but how about just clarifying that with something that just says it's possible to configure deletion, for example:

You are uploading an image to an external server. You won't be able to remove the image unless you have configured(/specified) deletion link in settings. Are you okay with this?

zneix on 10 Jul 2020

👍5

All 4 comments

Thing is, the user defines whether the deletion link will be handled or not by filling deletion URL field, meaning, they can type anything in there (or misconfigure that one field) and image uploader won't provide a valid deletion link, thus, what you suggest might give a fair amount of false positivities.

zneix on 10 Jul 2020

You are uploading an image to an external server. You won't be able to remove the image unless you have configured(/specified) deletion link in settings. Are you okay with this?

zneix on 10 Jul 2020

👍5

I bet you want to have something like "dynamic warning" that would change based on whether we have deletion link specified or not, but how about just clarifying that with something that just says it's possible to configure deletion, for example:

You are uploading an image to an external server. You won't be able to remove the image unless you have configured(/specified) deletion link in settings. Are you okay with this?

seems good to me

pajlada on 12 Jul 2020

🚀1

This issue does not provide enough useful features. As such there is a likely chance of this never being implemented. I will close this so it doesn't become a stale issue that never gets closed.

There is also no way of checking if the deletion link actually works.