Chatterino2: New highlight system: subscription colors gets affected by highlighted users colors

[TETYYS]

Describe the bug
Subscription color is ignored and user highlight color is used.

To reproduce

Chatterino version
Chatterino Nightly 2.1.7 (commit bfee75ec5, )

[leon-richardt]

I'm having a hard time reproducing this. Could you try walking me through the exact steps you took when adding the highlights?

[TETYYS]

i modified colors on some highlights in messages tab, dont remember which ones. then i set it all red on usernames

[leon-richardt]

Just to be sure: The user that triggered the subscription message was not part of your user highlights, correct?

[TETYYS]

thats correct

[TETYYS]

happens only when i set xqcow user highlight to red (others make no difference to subscription messages), not sure if thats because he's last or something

[leon-richardt]

Does the issue still occur when you remove and re-add the highlight for xqcow?

[TETYYS]

yes

i have removed some non-relevant highlights in messages tab in the screenshot, not sure if they make any difference

[leon-richardt]

Okay, I managed to reproduce after restarting Chatterino; leading me to believe that this might be a serialization issue.

[leon-richardt]

Quick update: I believe I have found the issue but I would rather do some more testing before opening a PR.

[leon-richardt]

From what I can find, #1522 should resolve this problem.

Good catch @TETYYS, and thanks for the report!