Chatterbot: Removing support for redundant database connection parameters

Created on 16 Aug 2017  路  3Comments  路  Source: gunthercox/ChatterBot

Right now, the MongoDB storage adapter and the SQL storage adapter each support both of the following parameters.

  • database: A simple string such as "chat-bot-database" that then gets turned into a database connection string by the storage adapter.
  • database_uri A database connection string.

I think it might simplify things if one of these parameters was removed. Considering they both almost do the same thing I don't think there would be too much of an issue if database was removed completely as a possible parameter for these two adapters.


"Explicit is better than implicit."
~ The Zen of Python

good first issue help wanted

All 3 comments

I'm working on this issue. Can I take it?

Yes, please do. Thank you :smile:

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

thedp picture thedp  路  4Comments

AmusingThrone picture AmusingThrone  路  3Comments

vkosuri picture vkosuri  路  4Comments

engrphil picture engrphil  路  3Comments

hochochoc picture hochochoc  路  3Comments