Charts: [stable/prometheus] request: document example sidecar

[chrisovergaauw]

Is this a request for help?: yes

I'm looking for more detailed information on something that does not seem to be documented.

---

Is this a BUG REPORT or FEATURE REQUEST? (choose one): FEATURE REQUEST
Version of Helm and Kubernetes: 2.13 & 1.13.3
Which chart: Prometheus

The README specifies that sidecars can be defined but it does not mention anything about the syntax. I'd like to learn how to do this and maybe enhance the values.yaml with an example.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

[chrisovergaauw]

I'd still like to see this improved.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Any further update will cause the issue/pull request to no longer be considered stale. Thank you for your contributions.

[chrisovergaauw]

Pretty disappointing...

[u2g-tg]

The implementation looks pretty simple in the Prometheus statefulset definition

  {{- if .Values.server.sidecarContainers }}
   {{- toYaml .Values.server.sidecarContainers | nindent 8 }}
   {{- end }}

If you define an list of container definitions at server.sidecarContainers in your Helm values, then the containers will be started as sidecars.

The container definition would be a full block as per any StatefulSet/Deployment spec.template.spec.containers: element