Charts: As of todays update, I am running into this issue. 'common' renamed RunLoopMode.commonModes

Created on 18 Sep 2018  ·  9Comments  ·  Source: danielgindi/Charts

What did you do?

Updated to new version of Charts on an iOS 12 project by running pod update in terminal

What did you expect to happen?

no errorrs

What happened instead?

screen shot 2018-09-17 at 7 34 57 pm

screen shot 2018-09-17 at 7 42 45 pm

Charts version/Branch/Commit Number:
Xcode version: 10
Swift version: 4.1
Platform(s) running Charts: 12
macOS version running Xcode:

Demo Project

ℹ Please link to or upload a project we can download that reproduces the issue.

Most helpful comment

image

All 9 comments

Me too

在pod 添加 试试

post_install do |installer|

  installer.pods_project.targets.each do |target|
      target.build_configurations.each do |config|
          if target.name == 'Charts'
              config.build_settings['SWIFT_VERSION'] = '4.2'
              else
              config.build_settings['SWIFT_VERSION'] = '4.1'
          end
      end
  end

end

在pod 添加

post_install do |installer|

  installer.pods_project.targets.each do |target|
      target.build_configurations.each do |config|
          if target.name == 'Charts'
              config.build_settings['SWIFT_VERSION'] = '4.2'
              else
              config.build_settings['SWIFT_VERSION'] = '4.1'
          end
      end
  end

end

Where is this code placed?

image

Please try this version:https://github.com/danielgindi/Charts/tree/4.0.0

@cythb stop asking people to try 4.0 branch. IT'S NOT FOR PUBLIC. Next time I saw you post like this, I will delete it.

Please note, we try to make sure master branch always work with latest Xcode and Swift; if you plan to upgrade your EVERY swift library to 4.2, you can take the new code. Otherwise, stick to old Chart library.

The new commits for Swift 4.2 will not work with lower versions.

@srn214 , @muzoman I had encounter same issue, thanks for solution 👍 , Could you please explain a bit more. Is this is setting swift version in build setting to 4.2 but why its working. Any help appreciated.

i just correct the code with

forMode: RunLoop.Mode.common

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Aungbandlab picture Aungbandlab  ·  4Comments

brytnvmg picture brytnvmg  ·  4Comments

cilasgimenez picture cilasgimenez  ·  4Comments

kwstasna picture kwstasna  ·  3Comments

guanyanlin picture guanyanlin  ·  3Comments