Charts: Set imagePullPolicy in init-containers in charts

Created on 15 Dec 2016  路  14Comments  路  Source: helm/charts

In K8S 1.5, the default value for imagePullPolicy was removed, so charts that are skipping this setting are failing to be installed.

Since imagePullPolicy is a configurable value, we should be respecting it in init-containers as well.

Affected charts:

  • [x] ghost #419
  • [ ] jasperreports #518
  • [x] joomla #488
  • [x] magento #418
  • [x] mediawiki #496
  • [x] opencart #497
  • [x] owncloud #417
  • [x] phabricator #426
  • [ ] phpbb #519
  • [x] prestashop #492
  • [ ] redmine #515
  • [x] testlink #493
  • [ ] sapho #514
lifecyclrotten

Most helpful comment

I'll give this a shot

All 14 comments

I'll give this a shot

Thanks @sputnick!!! Just a note that we'd appreciate if you can keep the PRs for each chart separate so that we can easily test and merge them.

ok @viglesiasce I was just wondering about that. I have to get the CNCF stuff signed as well in-house. Might not be done today because of that.

https://github.com/kubernetes/charts/pull/295 (same issue) was closed because kubernetes/kubernetes#38542

Looks like cockroachdb is the only one not updated for 1.5 yet cc @a-robinson

also zookeeper @lachie83

Ack, thanks for the ping. Sent out #338

looks like owncloud hit this #406

Charts still affected by this through their dependency

  • [ ] ghost
  • [ ] jasperreports
  • [ ] joomla
  • [ ] magento
  • [ ] mediawiki
  • [ ] opencart
  • [ ] owncloud
  • [ ] phabricator
  • [ ] phpbb
  • [ ] prestashop
  • [ ] redmine
  • [ ] testlink
  • [ ] sapho

confirm, stable/joomla fails in minikube (1.5.1)

stable/postgresql also effected

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

Prevent issues from auto-closing with an /lifecycle frozen comment.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle stale

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or @fejta.
/lifecycle rotten
/remove-lifecycle stale

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Was this page helpful?
0 / 5 - 0 ratings